-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lintTextSync method? #156
Comments
feross
added a commit
that referenced
this issue
Feb 21, 2017
Fixes: #156 Before: standardEngine.lintText(text, [opts], callback) After: results = standardEngine.lintText(text, [opts]) If an error occurs, an exception is thrown. Otherwise, a `results` object is returned.
Fair point. There's no need for this to be async. PR here: #157 |
feross
added a commit
that referenced
this issue
Feb 21, 2017
Fixes: #156 Before: standardEngine.lintText(text, [opts], callback) After: results = standardEngine.lintText(text, [opts]) If an error occurs, an exception is thrown. Otherwise, a `results` object is returned.
feross
added a commit
that referenced
this issue
Feb 21, 2017
Fixes: #156 Before: standardEngine.lintText(text, [opts], callback) After: results = standardEngine.lintText(text, [opts]) If an error occurs, an exception is thrown. Otherwise, a `results` object is returned.
cool, thanks |
feross
added a commit
that referenced
this issue
Apr 4, 2017
Fixes: standard/standard#807 - BREAKING: rename the syncronous `lintText` method to `lintTextSync` - Add an asyncronous `lintText` method (that just calls `lintTextSync` internally) This effectively undoes the breaking change introduced in 6.0.0, making it safe to upgrade from `standard-engine` 5.x to 7.x without introducing any breaking changes. Related: #156
FYI, this PR affects the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not cool that
.lintText
requires a callback and ESLint's method is synchronous, but we here forcecb
for no reason. Or okey, at least add.lintTextSync
method?There is existing problem for https://github.com/dtinth/atom-prettier-standard-formatter, which is based on https://github.com/dtinth/prettier-standard-formatter, which uses promises, exactly because the
standard
s lintText method.ping @dtinth, stay tuned :)
The text was updated successfully, but these errors were encountered: