Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking testers! Confirm that the version on master works so we can publish a new version #135

Closed
feross opened this issue Nov 17, 2020 · 7 comments · Fixed by #142
Closed

Comments

@feross
Copy link
Member

feross commented Nov 17, 2020

Thanks to @divlo's efforts in #132, this extension has been massively updated for the latest version of TypeScript and it now passes the ts-standard linter.

Since the changes were quite large, before we put out a new release, I'd like at least 5 VSCode users to run the code on master and report no problems.

If you'd like to test it out and confirm it works for your use case, then please follow these steps:

  1. Run npm install
  2. Run npm run package to build a .vsix file
  3. You can install it with code --install-extension vscode-standardjs.vsix

If everything works for you, post a comment here indicating it worked for you.

@elvis-pereira
Copy link

I just tested, it's working

@lucas-santoni
Copy link

lucas-santoni commented Nov 22, 2020

I tested master and noticed this: #126 (comment).

@yelwinsoe
Copy link
Contributor

I've just tested, it's working fine.

@toddbluhm
Copy link
Contributor

I have been using the master branch version since #132 landed and everything has been working great so far...though my testing has been limited to ts-standard usage.

@jamesorlakin
Copy link
Contributor

I can confirm master (on 0f92bb6) works with ts-standard and the new errorsAsWarnings setting.

image

However, I can't seem to get normal standard working in the same project. I've uninstalled ts-standard and plopped in standard instead, but then get a strange globbing error to do with the ignore library.
image

This project is not in a Git registry (no .gitignore) nor have I set anything ignore-ey that I'm aware of 🙂

@theoludwig
Copy link
Contributor

theoludwig commented Nov 29, 2020

Right @jamesorlakin!
There are always bugs ah ah... 😅

The issue was because of #140. I cancel the changes of the PR (locally) and it seems to work as expected everywhere, but of course we can't have multiple project as it was the purpose of the PR.
We will need to investigate further #140 before releasing v1.5.0.

Basically we remove && settings.engine !== 'standard' of this line https://github.com/standard/vscode-standardjs/blob/0f92bb6687eed39734d459c8a65594c67fd3d8aa/server/src/server.ts#L892

And it's working but it doesn't solve #140.

@theoludwig theoludwig mentioned this issue Dec 5, 2020
4 tasks
@lucas-santoni
Copy link

@divlo I can confirm that #126 (comment) is fixed for me on master. Thank you!

@theoludwig theoludwig unpinned this issue Feb 3, 2021
@theoludwig theoludwig linked a pull request Feb 3, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants