-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect brackets in filename #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it solves the issue, I tested it manually on my computer and resolved the conflicts.
We can now have linting in files like [test].js
.
Well done! @yuan9090
Since it's a bug fix and not a big change, I guess we can directy merge to master, if it was a feature request or something bigger, I would rather to have 2 approvals.
@feross Thank you. It works! |
I originally noticed the same issue in version 1.4.0. I tried {
"resource": "/Users/geo/Documents/code/dessert-frontend/pages/module/[id].tsx",
"owner": "standard",
"severity": 8,
"message": "Parsing error: \"parserOptions.project\" has been set for @typescript-eslint/parser.\nThe file does not match your project config: pages/module/%5Bid%5D.tsx.\nThe file must be included in at least one of the projects provided.",
"source": "ts-standard",
"startLineNumber": 1,
"startColumn": 1,
"endLineNumber": 1,
"endColumn": 1
} I'm working with a Next.js project. I'm using Running |
@geospace Thanks for your report, we'll try to fix this! |
This message appears in VSCode's "PROBLEMS" section. See here: It only appears for files such as "standard.engine": "ts-standard",
"standard.autoFixOnSave": true,
"standard.usePackageJson": true, Just in case, my complete Here is {
"name": "front",
"version": "0.1.0",
"private": true,
"scripts": {
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "ts-standard --fix"
},
"dependencies": {
"@apollo/client": "^3.2.7",
"github-markdown-css": "^4.0.0",
"graphql": "^15.4.0",
"lodash": "^4.17.20",
"mobile-detect": "^1.4.4",
"next": "^10.0.2",
"normalize.css": "^8.0.1",
"react": "17.0.1",
"react-dom": "17.0.1",
"react-grid-system": "^7.1.1",
"react-icons": "^3.10.0",
"react-infinite-scroll-component": "^5.1.0",
"react-markdown": "^5.0.3",
"react-select": "^3.1.0",
"react-toastify": "^6.1.0"
},
"devDependencies": {
"@types/lodash": "^4.14.165",
"@types/node": "^14.14.9",
"@types/react": "^17.0.0",
"@types/react-dom": "^17.0.0",
"@types/react-select": "^3.0.26",
"@types/webpack": "^4.41.25",
"gray-matter": "^4.0.2",
"next-mdx-remote": "^1.0.0",
"ts-standard": "^9.0.0",
"typescript": "4.0.5"
},
"ts-standard": {
"ignore": [
"next-env.d.ts"
]
}
} And here is {
"compilerOptions": {
"target": "es5",
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": false,
"skipLibCheck": false,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"
},
"exclude": ["node_modules"],
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"]
} Let me know if I can do anything else to help you debug this! I'll try to dig a bit more myself over the weekend or at least create a minimal repository that reproduces the issue. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Can Detect brackets in filename.
Which issue (if any) does this pull request address?
fix #102 vscode-eslint#977
Is there anything you'd like reviewers to focus on?