fix: change working directory prior to loading the engine #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
theoludwig
approved these changes
Nov 6, 2022
theoludwig
changed the title
|
🎉 Congrats on getting your first pull request landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
The typescript linter (
ts-standard) needs to find the configuration file (tsconfig.jsonortsconfig.eslint.json) in order to work. It searches, starting from the current working directory. When running the e2e test script and, I suspect, starting VSCode from a Linux shell, the CWD is set correctly and everything works. However this is not guaranteed - for example running from the Windows start menu has the CWD set to the installation directory.The commit c4d3763 temporarily changes to the workspace folder before loading the typescript engine and restores the previous value afterwards. The workspace folder seems to be the correct one, at least for single workspace projects.
As mentioned the test code coincidentally sets the CWD correctly so this error never appears when running
npm test. Commit 663b6fb changes to a different directory (actually the temporary directory) prior to starting each test run which causes thets-standardtest to fail without the fix also being applied.Which issue (if any) does this pull request address?
#483
Is there anything you'd like reviewers to focus on?