Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to reorder entries #51

Merged
merged 16 commits into from
May 27, 2021
Merged

feat: ability to reorder entries #51

merged 16 commits into from
May 27, 2021

Conversation

johnny243
Copy link
Contributor

@johnny243 johnny243 commented May 25, 2021

  • verify user experience in mobile
  • add option to reorder by service (ascending or descending)
  • show handle that indicates the entries can dragged
  • verify theme support
Peek.2021-05-26.13-26.mp4

closes #19

@moughxyz
Copy link
Member

👏👏

We can change alert copy to maybe "Are you sure you want to auto-sort all entries alphabetically based on service name?" or something similar.

@johnny243 johnny243 marked this pull request as ready for review May 26, 2021 17:27
@johnny243 johnny243 requested a review from moughxyz May 26, 2021 17:27
@moughxyz
Copy link
Member

How is this handled on mobile btw?

@johnny243
Copy link
Contributor Author

How is this handled on mobile btw?

On mobile, you need to long press to drag-n-drop an entry.

@johnny243 johnny243 merged commit 78e4f76 into develop May 27, 2021
@johnny243 johnny243 deleted the feat/reorder-entries branch May 27, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants