Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- '3.1'
- '3.2'
- '3.3'
- '3.4'

runs-on: ${{ matrix.os }}

Expand Down
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
## [unreleased]

- Update Gems
- regexp_parser@2.10.0
- rubocop-ast@1.40.0
- rubocop@1.73.2
- rubocop-performance@1.24.0
- standard-performance@1.7.0
- standard@1.47.0
- add Ruby 3.4 to Github Action Runner

## [1.2.0]

- Update to [rubocop-rails@2.26.0](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md#2260-2024-08-24)
Expand Down
41 changes: 22 additions & 19 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ PATH
specs:
standard-rails (1.2.0)
lint_roller (~> 1.0)
rubocop-rails (~> 2.26.0)
rubocop-rails (~> 2.30.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -49,27 +49,30 @@ GEM
rack (3.1.7)
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.9.2)
rubocop (1.66.1)
regexp_parser (2.10.0)
rubocop (1.73.2)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.38.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.34.1)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.38.1)
parser (>= 3.3.1.0)
rubocop-performance (1.22.1)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rails (2.26.0)
rubocop-performance (1.24.0)
lint_roller (~> 1.1)
rubocop (>= 1.72.1, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop-rails (2.30.3)
activesupport (>= 4.2.0)
lint_roller (~> 1.1)
rack (>= 1.1)
rubocop (>= 1.52.0, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop (>= 1.72.1, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
ruby-progressbar (1.13.0)
securerandom (0.3.1)
simplecov (0.22.0)
Expand All @@ -78,18 +81,18 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.13.1)
simplecov_json_formatter (0.1.4)
standard (1.41.1)
standard (1.47.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.66.0)
rubocop (~> 1.73.0)
standard-custom (~> 1.0.0)
standard-performance (~> 1.5)
standard-performance (~> 1.7)
standard-custom (1.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.50)
standard-performance (1.5.0)
standard-performance (1.7.0)
lint_roller (~> 1.1)
rubocop-performance (~> 1.22.0)
rubocop-performance (~> 1.24.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.6.0)
Expand Down
14 changes: 0 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,6 @@ plugins:
target_rails_version: 7.0
```

### Ignoring violations from old migrations

Rails migrations are intended to be written as forward-compatible and subsequently unchanged, but they may contain Standard Ruby violations. Rather than apply fixes to those old migrations (and risk changing their behavior), you can ignore them in your `.standard.yml` like this:

```ruby
ignore:
# Legacy migrations
- 'db/migrate/201*.rb'
- 'db/migrate/2020*.rb'
- 'db/migrate/2021*.rb'
- 'db/migrate/2022*.rb'
- 'db/migrate/2023*.rb'
```

## Code of Conduct

This project follows Test Double's [code of
Expand Down
9 changes: 9 additions & 0 deletions config/base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Lint/SafeNavigationChain:
- try!
- in?

Lint/UselessAccessModifier:
Enabled: false

Rails/ActionControllerFlashBeforeRender:
Enabled: false

Expand Down Expand Up @@ -237,6 +240,9 @@ Rails/MatchRoute:
Rails/MigrationClassName:
Enabled: true

Rails/MultipleRoutePaths:
Enabled: true

Rails/NegateInclude:
Enabled: false

Expand Down Expand Up @@ -366,6 +372,9 @@ Rails/SquishedSQLHeredocs:
Rails/StripHeredoc:
Enabled: true

Rails/StrongParametersExpect:
Enabled: false

Rails/TableNameAssignment:
Enabled: false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# of RuboCop built-in cops in this file, we need to monitor it for changes
# in rubocop-rails and keep it up to date.
#
# Last updated from rubocop-rails v2.26.0
# Last updated from rubocop-rails v2.30.3

# frozen_string_literal: true

Expand All @@ -19,14 +19,14 @@
require_path = Pathname.new(Gem.loaded_specs["rubocop-rails"].full_require_paths.first)
require require_path.join("rubocop/rails")
require require_path.join("rubocop/rails/version")
# require_relative 'rubocop/rails/inject'
require require_path.join("rubocop/rails/schema_loader")
require require_path.join("rubocop/rails/schema_loader/schema")

# RuboCop::Rails::Inject.defaults!

require require_path.join("rubocop/rails/plugin")
require require_path.join("rubocop/cop/rails_cops")

require require_path.join("rubocop/rails/migration_file_skippable")
RuboCop::Rails::MigrationFileSkippable.apply_to_cops!

RuboCop::Cop::Style::HashExcept.minimum_target_ruby_version(2.0)

RuboCop::Cop::Style::InverseMethods.singleton_class.prepend(
Expand Down
2 changes: 1 addition & 1 deletion standard-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "lint_roller", "~> 1.0"
spec.add_dependency "rubocop-rails", "~> 2.26.0"
spec.add_dependency "rubocop-rails", "~> 2.30.0"
end
Loading