Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errant semantic block cases around class mutation #248

Closed
dnsco opened this issue Jan 19, 2021 · 2 comments
Closed

Errant semantic block cases around class mutation #248

dnsco opened this issue Jan 19, 2021 · 2 comments

Comments

@dnsco
Copy link

dnsco commented Jan 19, 2021

Given that the point of this block is to add a method to the struct, I think it should be do end.

ValueObject = Struct.new(:events) {
    def random_name
      @event_name ||= events.sample.name
    end
  }

I've also hit this issue a couple other times when doing metaprommey things.

@dnsco
Copy link
Author

dnsco commented Jan 19, 2021

just saw #109

@dnsco dnsco mentioned this issue Jan 19, 2021
@jmkoni
Copy link
Contributor

jmkoni commented Jan 22, 2021

What we would recommend is the following:

class ValueObject < Struct.new(:events)
  def random_name
     @event_name ||= events.sample.name
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants