Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disable the Semantic Block rule? #255

Closed
dnsco opened this issue Feb 5, 2021 · 0 comments · Fixed by #263
Closed

Is there a way to disable the Semantic Block rule? #255

dnsco opened this issue Feb 5, 2021 · 0 comments · Fixed by #263

Comments

@dnsco
Copy link

dnsco commented Feb 5, 2021

I get that the entire point of this project is to avoid these kinds of discussions and bikeshedding and this would undermine the intent of the project.

I also understand and agree with the intent behind the semantic block rule.

but

It seems impossible to actually get this rule right because there is way too much ruby code in the wild and this rule would have to know every case where it could mess up.

I opened #248 as an example of a class of issues, I was advised to change this specific instance, but I have encountered other cases that this doesn't address (this rule makes usage of the Dry::Initializer gem even uglier ;-) )

#109 was closed out because the specific issues mentioned in it had apparently been addressed, but I feel like the issue was also about the underlying problem.

I think #94 and #246 are also related to this.

I seriously want to thank all of the maintainers for making such a great library. I really appreciate your hard work.

If I have to– I guess I can just accept that standard will make my code ugly in places that goes against even its own (and (Jim Weirich's) intent, but it feels like this bummer is bigger than "i disagree with the code style choice" and actually one around correctness.

I understand if this issue gets insta-closed, but I do think there should be an open issue (this one or #109) until there is an explicitly stated decision the problem, rather than closing out issues around specific instances.

Seriously, Thanks again for this software, your time and effort are appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant