Change Layout/DotPosition from trailing to leading #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind updating the README? Pick your poison |
JoshCheek
force-pushed
the
set-layout-dot-position-to-leading
branch
from
fea2c29 to
92176d6
Compare
|
Sorry about that. I checked the files for trailing dots and there weren't any, forgot about the README. |
|
Ok, marking this approved. Will merge it this week once I have enough time to respond promptly with any potential issues a release raises (IIRC, this will be the highest-churn change since announcing standard). If I don't get around to merging it this week, please pester and remind me! Thanks for your work on this. |
|
This will go in to rubyfmt too!
On Sun, 10 Feb 2019 at 17:31, Justin Searls ***@***.***> wrote:
Ok, marking this approved. Will merge it this week once I have enough time
to respond promptly with any potential issues a release raises (IIRC, this
will be the highest-churn change since announcing standard).
If I don't get around to merging it this week, please pester and remind me!
Thanks for your work on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF5lnKa29FK6l55AqTZ4q2Jx63w6XPxks5vMJ3HgaJpZM4ap_ZD>
.
--
Sam Phippen
|
|
🎉 Landed in 0.0.27 🎉 Thanks @JoshCheek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75