Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark internal headers private #362

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

CyanoKobalamyne
Copy link
Collaborator

Follow up to #356.

Also removed some unused headers and fixed some formatting errors.

Copy link
Collaborator

@yoni206 yoni206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really have a developer guide right? But maybe there is some meaningful place where this can be documented? Perhaps somewhere in the readme?

@barrettcw
Copy link
Collaborator

Why not use the github wiki? This could be a start of something that eventually becomes a developer's guide.

Copy link
Collaborator

@yoni206 yoni206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess documenting this in the wiki can be done separately.

@CyanoKobalamyne CyanoKobalamyne merged commit 7aace66 into main Nov 5, 2024
24 checks passed
@CyanoKobalamyne CyanoKobalamyne deleted the mark-private-headers branch November 5, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants