Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search feature #2

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Add search feature #2

merged 3 commits into from
Jul 30, 2022

Conversation

KonradIT
Copy link
Contributor

This pull request:

  • Adds the search (for usernames) feature to the API
  • Makes the initialization of the API class smoother (1)
  • Exposes search feature to the CLI

1:

Before After
AttributeError: 'Api' object has no attribute 'auth_id' truthbrush.api.LoginErrorException: Username is missing.

@lxcode
Copy link
Contributor

lxcode commented Jul 30, 2022

Sorry for the delay here — could you either make an option to specify the type of search, or rename the method? I'd like it to be compatible with future support for the hashtag and statuses search endpoints.

@KonradIT
Copy link
Contributor Author

Renamed to search_users.

@lxcode lxcode merged commit 397c0e2 into stanfordio:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants