Pull Statuses (created after datetime) #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is still letting the latest status come through, so need to investigate
Break if we are looking at the same timestamp as the latest post (when they are equal)
Update docstring
s2t2
commented
Sep 2, 2023
|
|
||
| params = {} | ||
| id = self.lookup(username)["id"] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
s2t2
commented
Sep 2, 2023
| os.getenv("TRUTHSOCIAL_PASSWORD"), | ||
| os.getenv("TRUTHSOCIAL_TOKEN"), | ||
| ) | ||
| api = Api() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
milesmcc
reviewed
Oct 1, 2023
| @@ -80,6 +82,36 @@ truthbrush user HANDLE | |||
|
|
|||
| Contributions are encouraged! For small bug fixes and minor improvements, feel free to just open a PR. For larger changes, please open an issue first so that other contributors can discuss your plan, avoid duplicated work, and ensure it aligns with the goals of the project. Be sure to also follow the [code of conduct](CODE_OF_CONDUCT.md). Thanks! | |||
|
|
|||
| Development setup (ensure you have [Poetry](https://python-poetry.org/) installed): | |||
There was a problem hiding this comment.
@s2t2 made a few small changes to the README here — head's up.
milesmcc
requested changes
Oct 1, 2023
s2t2
commented
Oct 2, 2023
milesmcc
approved these changes
Oct 2, 2023
|
Thanks @s2t2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
created_afterparameter of theApi#pull_statusesfunction to be a datetime, instead of a date, so we can collect statuses posted later in the same day as some previously collected status. Makes this an optional parameter, so default will pull entire timeline.We could alternatively consider using an approach based on status identifiers instead of status timestamps (assuming the identifiers are in order of their creation). Implements a new optional
since_idparameter for this purpose.Implements automated testing to ensure this functionality works.