Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Site #38

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Documentation Site #38

wants to merge 21 commits into from

Conversation

s2t2
Copy link
Contributor

@s2t2 s2t2 commented Jul 17, 2024

Hi, I was getting back into this package and was interested in checking out some documentation.

So I created an auto-generated documentation site using Quarto and the quartodoc package.

It will automatically generate the documentation pages based on docstrings in the truthbrush package.

This PR is in draft status. I figured I would share, in case you would like to discuss, poke around, and further customize the documentation site (for example to use more of the README content).

Notes and Todos:

  • I used a docs/requirements.txt file for specifying packages for the documentation site, but we would probably want to change that to use poetry (I wasn't entirely sure how)
  • We can set up a GitHub Action to automatically publish the documentation site to GitHub pages. We would just need to update the "quarto-pages" workflow file to use poetry instead of installing from the requirements file.
  • I chose "google" as the docstring type, because one of the functions uses that convention, but we can use "numpy" style instead, depending on your preference.

FYI I have published a copy of the documentation site with my fork, for reference:
https://s2t2.github.io/truthbrush/


Screenshot 2024-07-17 at 4 35 44 PM
Screenshot 2024-07-17 at 4 51 32 PM

docs/README.md Outdated Show resolved Hide resolved
@s2t2
Copy link
Contributor Author

s2t2 commented Jul 22, 2024

FYI regarding builds that are passing on my repo but failing on this upstream repo:

  • the "python-application" build requires username and password to be set as repository secrets
  • the "quarto-pages" build requires github pages to be set up

@s2t2 s2t2 marked this pull request as ready for review July 29, 2024 17:03
@s2t2
Copy link
Contributor Author

s2t2 commented Jul 29, 2024

I think this is ready for review, if we would like to implement the documentation site!

@lxcode lxcode requested a review from milesmcc July 31, 2024 13:18
@milesmcc
Copy link
Collaborator

milesmcc commented Jul 31, 2024

Hi! Thanks for putting this together. I'm a bit concerned about the maintenance burden -- is the value of the site really greater than the cost of maintaining it? I'm inclined to just keep the README high quality. I realize this is largely auto generated but it's another thing that we're going to have to think about.

@s2t2
Copy link
Contributor Author

s2t2 commented Aug 28, 2024

Hi @milesmcc thanks for your reply.

I would be happy to own / drive maintenance of the documentation site, if that is helpful.

Most of the effort has already been done in setting it up. Moving forward we would mainly need to focus on making sure functions have docstrings. The build process is automated through GitHub Actions so whenever we merge code into the main branch the docsite will update.

It has been helpful for me to look at my fork of the documentation site. I would love to be able to not have to maintain my own parallel fork separate from the main repo. But I understand if you ultimately would not like to implement the documentation site.

I'd be happy to discuss further, give a walkthrough of the main components, etc. Feel free to email me at prof.mj.rossetti@gmail.com if helpful.

@milesmcc
Copy link
Collaborator

Got it! Any chance you can move the test changes out of this PR? It'd be helpful to merge those even as we figure out how to best approach the documentation site (which I personally remain neutral about).

@s2t2
Copy link
Contributor Author

s2t2 commented Sep 11, 2024 via email

@s2t2 s2t2 mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants