Add sacrebleu and rouge-score as required dependencies #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the project, installing dependencies with
pip install -r requirements.txt
and running tests withpython3 -m pytest
currently fails sincesacrebleu
androuge-score
are not explicitly listed as dependencies:This PR adds the packages in question as dependencies in
setup.py
andrequirements.txt
, fixing the tests and solving #4.Questions:
setup.py
be updated?requirements-dev.txt
with frozen package versions where the tests are known to run - which could potentially make it easier to debug breakages due to backwards-incompatible changes in dependencies. Should this file be renamed or included at all?