Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released versions contain test data #389

Closed
weiznich opened this issue Dec 11, 2024 · 1 comment · Fixed by #390
Closed

Released versions contain test data #389

weiznich opened this issue Dec 11, 2024 · 1 comment · Fixed by #390

Comments

@weiznich
Copy link
Contributor

While reviewing some updates to our dependencies I noticed that the last version (3.9.0) of os_info uploaded to crates.io contains unnecessary test data in src/linux/tests. While this is not a problem on it's own it is at least wasteful as these data need not to be there for having a correctly working crate.

Cargo allows to exclude such files via an entry in your Cargo.toml file: https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields

See the diff here: https://diff.rs/os_info/3.8.2/3.9.0/

If you are interested in addressing that I'm happy to contribute a PR for this.

@stanislav-tkach
Copy link
Owner

This seems reasonable, thanks for the suggestion! If you want to do that - go ahead, I would be happy if this is addressed.

weiznich added a commit to GiGainfosystems/os_info that referenced this issue Dec 11, 2024
This commit removes the test data from the published crate.

Fixes stanislav-tkach#389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants