Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting version for macOS Betas #103

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Support getting version for macOS Betas #103

merged 2 commits into from
Sep 10, 2019

Conversation

zacbrown
Copy link
Contributor

@zacbrown zacbrown commented Sep 9, 2019

  • Modify the version parsing code to support macOS Beta versions which don't include a patch version (e.g. 10.15).

Signed-off-by: Zac Brown zacbrown@users.noreply.github.com

…h don't include a patch version (e.g. 10.15).

Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
@zacbrown
Copy link
Contributor Author

zacbrown commented Sep 9, 2019

The lint failures do not appear to be related to my change.

…h versions.

Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
@codecov-io
Copy link

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files           3        3           
  Lines         127      127           
=======================================
  Hits          105      105           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5672990...3ae2ce9. Read the comment docs.

@stanislav-tkach
Copy link
Owner

Thank you for the pull request. As far as I can see, the Travis build is failing because of TryFrom used in cargo-audit which isn't related to your changes. I'm going to merge and release a new version soon.

@stanislav-tkach stanislav-tkach merged commit 89b7505 into stanislav-tkach:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants