Add distinct OS type for RedHatEnterprise and associated test cases. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add parsing for RHEL in lsb_release.rs. - Add test cases for RHEL 6,7,8. Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
- Add RedHatEnterprise as a variant to the Linux mod tests. Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
|
The lint failure does not appear to be related to my change: https://travis-ci.org/DarkEld3r/os_info/jobs/621258815?utm_medium=notification&utm_source=github_status Is it a requirement to fix it for my change? |
|
Sorry for the late replay and thank you for the pull request. You can ignore the lint, I'm going to fix it later as a separate pull request. |
stanislav-tkach
approved these changes
Dec 9, 2019
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for Red Hat Enterprise Linux and provides test cases for RHEL 6, 7, and 8 (the current actively supported versions). This change mirrors the Centos code in that it relies on
lsb_releasefor its version parsing information.This change creates a new type variant (RedHatEnterprise) which is distinct from Redhat as per Red Hat's nomenclature, the "Red Hat" distribution is defunct as of 2003. It seemed prudent to make the distinction obvious as RHEL is definitely not Red Hat.