Add support for Oracle Linux. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
|
@DarkEld3r - Will take a look. Thanks for the feedback! |
…ue variant to make it not specific to Oracle Linux. - Use lifetime'ed &str instead of creating a String object unnecessarily for parsing out the version using Matcher::KeyValue. - Simplify some Option::map calls to pass the fully qualified function to apply to the Option types. Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
stanislav-tkach
approved these changes
Mar 9, 2020
|
Thanks for the effort! I will release a new version shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support both in the
lsb_releaseandfilebased checkers for Oracle Linux.One important note: Oracle Linux has an unfortunate artifact where it contains an
/etc/redhat-releasefile that identifies itself as RHEL. In order to pre-empt this, I've added new parsing that looks for the/etc/os-releasefile which is on Oracle Linux machines. This file is checked for first in order to pre-empt misidentification of Oracle Linux as RHEL.I've tested this code on Oracle Linux 8.1 and Oracle Linux 7.5, both with and without
lsb_releaseand it worked as expected.