Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend VersionType enum #211

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Extend VersionType enum #211

merged 5 commits into from
Aug 13, 2020

Conversation

stanislav-tkach
Copy link
Owner

No description provided.

@stanislav-tkach stanislav-tkach changed the title Extend VersionType enum [WIP] Extend VersionType enum Aug 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2020

Codecov Report

Merging #211 into master will decrease coverage by 0.11%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   83.68%   83.57%   -0.12%     
==========================================
  Files          12       12              
  Lines         472      487      +15     
==========================================
+ Hits          395      407      +12     
- Misses         77       80       +3     
Impacted Files Coverage Δ
os_info/src/version.rs 84.94% <80.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe960a...ee81eb7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

🤠 Cargo bloat for toolchain stable-x86_64-unknown-linux-gnu 🤠

@@ Size breakdown @@

Size       1.11 MB
Text size  1.11 MB

No changes to crate sizes

Dependency tree
@@ Dependency tree @@
Count: 50

├─ env_logger v0.7.1
│  ├─ atty v0.2.14
│  │  └─ libc v0.2.74
│  ├─ humantime v1.3.0
│  │  └─ quick-error v1.2.3
│  ├─ log v0.4.11
│  │  └─ cfg-if v0.1.10
│  ├─ regex v1.3.9
│  │  ├─ aho-corasick v0.7.13
│  │  │  └─ memchr v2.3.3
│  │  ├─ memchr v2.3.3
│  │  ├─ regex-syntax v0.6.18
│  │  └─ thread_local v1.0.1
│  │     └─ lazy_static v1.4.0
│  └─ termcolor v1.1.0
├─ log v0.4.11 
├─ os_info v2.0.8 (/home/runner/work/os_info/os_info/os_info)
│  └─ log v0.4.11 
└─ structopt v0.3.16
   ├─ clap v2.33.2
   │  ├─ ansi_term v0.11.0
   │  ├─ atty v0.2.14 
   │  ├─ bitflags v1.2.1
   │  ├─ strsim v0.8.0
   │  ├─ textwrap v0.11.0
   │  │  └─ unicode-width v0.1.8
   │  ├─ unicode-width v0.1.8
   │  └─ vec_map v0.8.2
   ├─ lazy_static v1.4.0
   └─ structopt-derive v0.4.9
      ├─ heck v0.3.1
      │  └─ unicode-segmentation v1.6.0
      ├─ proc-macro-error v1.0.4
      │  ├─ proc-macro-error-attr v1.0.4
      │  │  ├─ proc-macro2 v1.0.19
      │  │  │  └─ unicode-xid v0.2.1
      │  │  ├─ quote v1.0.7
      │  │  │  └─ proc-macro2 v1.0.19 
      │  │  └─ version_check v0.9.2
      │  ├─ proc-macro2 v1.0.19 
      │  ├─ quote v1.0.7 
      │  ├─ syn v1.0.38
      │  │  ├─ proc-macro2 v1.0.19 
      │  │  ├─ quote v1.0.7 
      │  │  └─ unicode-xid v0.2.1
      │  └─ version_check v0.9.2
      ├─ proc-macro2 v1.0.19 
      ├─ quote v1.0.7 
      └─ syn v1.0.38 

Commit: 5250110 (Compare with baseline commit)

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

🍎 Cargo bloat for toolchain stable-x86_64-apple-darwin 🍎

@@ Size breakdown @@

Size       1.11 MB
Text size  1.11 MB

No changes to crate sizes

Dependency tree
@@ Dependency tree @@
Count: 50

├─ env_logger v0.7.1
│  ├─ atty v0.2.14
│  │  └─ libc v0.2.74
│  ├─ humantime v1.3.0
│  │  └─ quick-error v1.2.3
│  ├─ log v0.4.11
│  │  └─ cfg-if v0.1.10
│  ├─ regex v1.3.9
│  │  ├─ aho-corasick v0.7.13
│  │  │  └─ memchr v2.3.3
│  │  ├─ memchr v2.3.3
│  │  ├─ regex-syntax v0.6.18
│  │  └─ thread_local v1.0.1
│  │     └─ lazy_static v1.4.0
│  └─ termcolor v1.1.0
├─ log v0.4.11 
├─ os_info v2.0.8 (/Users/runner/work/os_info/os_info/os_info)
│  └─ log v0.4.11 
└─ structopt v0.3.16
   ├─ clap v2.33.2
   │  ├─ ansi_term v0.11.0
   │  ├─ atty v0.2.14 
   │  ├─ bitflags v1.2.1
   │  ├─ strsim v0.8.0
   │  ├─ textwrap v0.11.0
   │  │  └─ unicode-width v0.1.8
   │  ├─ unicode-width v0.1.8
   │  └─ vec_map v0.8.2
   ├─ lazy_static v1.4.0
   └─ structopt-derive v0.4.9
      ├─ heck v0.3.1
      │  └─ unicode-segmentation v1.6.0
      ├─ proc-macro-error v1.0.4
      │  ├─ proc-macro-error-attr v1.0.4
      │  │  ├─ proc-macro2 v1.0.19
      │  │  │  └─ unicode-xid v0.2.1
      │  │  ├─ quote v1.0.7
      │  │  │  └─ proc-macro2 v1.0.19 
      │  │  └─ version_check v0.9.2
      │  ├─ proc-macro2 v1.0.19 
      │  ├─ quote v1.0.7 
      │  ├─ syn v1.0.38
      │  │  ├─ proc-macro2 v1.0.19 
      │  │  ├─ quote v1.0.7 
      │  │  └─ unicode-xid v0.2.1
      │  └─ version_check v0.9.2
      ├─ proc-macro2 v1.0.19 
      ├─ quote v1.0.7 
      └─ syn v1.0.38 

Commit: 5250110 (Compare with baseline commit)

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

🏢 Cargo bloat for toolchain stable-x86_64-pc-windows-gnu 🏢

@@ Size breakdown @@

Size       1.99 MB
Text size  1.99 MB

No changes to crate sizes

Dependency tree
@@ Dependency tree @@
Count: 53

├─ env_logger v0.7.1
│  ├─ atty v0.2.14
│  │  └─ winapi v0.3.9
│  │     └─ winapi-x86_64-pc-windows-gnu v0.4.0
│  ├─ humantime v1.3.0
│  │  └─ quick-error v1.2.3
│  ├─ log v0.4.11
│  │  └─ cfg-if v0.1.10
│  ├─ regex v1.3.9
│  │  ├─ aho-corasick v0.7.13
│  │  │  └─ memchr v2.3.3
│  │  ├─ memchr v2.3.3
│  │  ├─ regex-syntax v0.6.18
│  │  └─ thread_local v1.0.1
│  │     └─ lazy_static v1.4.0
│  └─ termcolor v1.1.0
│     └─ winapi-util v0.1.5
│        └─ winapi v0.3.9 
├─ log v0.4.11 
├─ os_info v2.0.8 (D:\a\os_info\os_info\os_info)
│  ├─ log v0.4.11 
│  └─ winapi v0.3.9 
└─ structopt v0.3.16
   ├─ clap v2.33.2
   │  ├─ atty v0.2.14 
   │  ├─ bitflags v1.2.1
   │  ├─ strsim v0.8.0
   │  ├─ textwrap v0.11.0
   │  │  └─ unicode-width v0.1.8
   │  ├─ unicode-width v0.1.8
   │  └─ vec_map v0.8.2
   ├─ lazy_static v1.4.0
   └─ structopt-derive v0.4.9
      ├─ heck v0.3.1
      │  └─ unicode-segmentation v1.6.0
      ├─ proc-macro-error v1.0.4
      │  ├─ proc-macro-error-attr v1.0.4
      │  │  ├─ proc-macro2 v1.0.19
      │  │  │  └─ unicode-xid v0.2.1
      │  │  ├─ quote v1.0.7
      │  │  │  └─ proc-macro2 v1.0.19 
      │  │  └─ version_check v0.9.2
      │  ├─ proc-macro2 v1.0.19 
      │  ├─ quote v1.0.7 
      │  ├─ syn v1.0.38
      │  │  ├─ proc-macro2 v1.0.19 
      │  │  ├─ quote v1.0.7 
      │  │  └─ unicode-xid v0.2.1
      │  └─ version_check v0.9.2
      ├─ proc-macro2 v1.0.19 
      ├─ quote v1.0.7 
      └─ syn v1.0.38 

Commit: 5250110 (Compare with baseline commit)

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

🏢 Cargo bloat for toolchain stable-i686-pc-windows-gnu 🏢

@@ Size breakdown @@

Size       1.73 MB
Text size  1.73 MB

No changes to crate sizes

Dependency tree
@@ Dependency tree @@
Count: 53

├─ env_logger v0.7.1
│  ├─ atty v0.2.14
│  │  └─ winapi v0.3.9
│  │     └─ winapi-i686-pc-windows-gnu v0.4.0
│  ├─ humantime v1.3.0
│  │  └─ quick-error v1.2.3
│  ├─ log v0.4.11
│  │  └─ cfg-if v0.1.10
│  ├─ regex v1.3.9
│  │  ├─ aho-corasick v0.7.13
│  │  │  └─ memchr v2.3.3
│  │  ├─ memchr v2.3.3
│  │  ├─ regex-syntax v0.6.18
│  │  └─ thread_local v1.0.1
│  │     └─ lazy_static v1.4.0
│  └─ termcolor v1.1.0
│     └─ winapi-util v0.1.5
│        └─ winapi v0.3.9 
├─ log v0.4.11 
├─ os_info v2.0.8 (D:\a\os_info\os_info\os_info)
│  ├─ log v0.4.11 
│  └─ winapi v0.3.9 
└─ structopt v0.3.16
   ├─ clap v2.33.2
   │  ├─ atty v0.2.14 
   │  ├─ bitflags v1.2.1
   │  ├─ strsim v0.8.0
   │  ├─ textwrap v0.11.0
   │  │  └─ unicode-width v0.1.8
   │  ├─ unicode-width v0.1.8
   │  └─ vec_map v0.8.2
   ├─ lazy_static v1.4.0
   └─ structopt-derive v0.4.9
      ├─ heck v0.3.1
      │  └─ unicode-segmentation v1.6.0
      ├─ proc-macro-error v1.0.4
      │  ├─ proc-macro-error-attr v1.0.4
      │  │  ├─ proc-macro2 v1.0.19
      │  │  │  └─ unicode-xid v0.2.1
      │  │  ├─ quote v1.0.7
      │  │  │  └─ proc-macro2 v1.0.19 
      │  │  └─ version_check v0.9.2
      │  ├─ proc-macro2 v1.0.19 
      │  ├─ quote v1.0.7 
      │  ├─ syn v1.0.38
      │  │  ├─ proc-macro2 v1.0.19 
      │  │  ├─ quote v1.0.7 
      │  │  └─ unicode-xid v0.2.1
      │  └─ version_check v0.9.2
      ├─ proc-macro2 v1.0.19 
      ├─ quote v1.0.7 
      └─ syn v1.0.38 

Commit: 5250110 (Compare with baseline commit)

@stanislav-tkach
Copy link
Owner Author

stanislav-tkach commented Aug 8, 2020

Perhaps the date should be stored as a simple string instead of chrono::Date.

@stanislav-tkach stanislav-tkach changed the title [WIP] Extend VersionType enum Extend VersionType enum Aug 13, 2020
@stanislav-tkach stanislav-tkach merged commit 1b6551c into master Aug 13, 2020
@stanislav-tkach stanislav-tkach deleted the rolling-version branch August 13, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants