Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Side Bar Area will Return Error #82

Closed
stanleyowen opened this issue Sep 14, 2021 · 0 comments · Fixed by #89
Closed

Clicking Side Bar Area will Return Error #82

stanleyowen opened this issue Sep 14, 2021 · 0 comments · Fixed by #89
Assignees
@stanleyowen
Labels
area: beta area: production bug Something isn't working fixed Bug has been fixed and shipped to production
Milestone
v0.2.5

Comments

@stanleyowen
Copy link
Owner

Describe the bug
When clicking the side bar area which has no child element will return error in the console with the following message:

Uncaught TypeError: Cannot read properties of undefined (reading 'innerText')
    at onClick (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at Object.qe (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at Ge (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at 7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1
    at Cr (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at xr (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at 7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1
    at Le (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)
    at 7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1
    at Nr (7547eacd0da2d316ddf37e515cf466cf17ef4608.js:1)

To Reproduce
Steps to reproduce the behavior:

  1. Go to lofi-players.netlify.app
  2. Click on any surfaces in side bar which doesn't has any element
  3. Open Dev Tools > Console
  4. See error

Expected behavior
No error was returned from console.

Screenshots
Clicking Side Bar Area will Return Error

Desktop (please complete the following information):

  • OS: Windows 10 OS Version 2009 (Build 19043.1202)
  • Browser Chrome
  • Version 93.0.4577.63
@stanleyowen stanleyowen added the bug Something isn't working label Sep 14, 2021
@stanleyowen stanleyowen self-assigned this Sep 14, 2021
@stanleyowen stanleyowen added the approved Issues have been confirmed by our team label Sep 14, 2021
@stanleyowen stanleyowen added this to the v0.2.5 milestone Sep 14, 2021
stanleyowen added a commit that referenced this issue Sep 14, 2021
@stanleyowen
Move switchTab function inside child element (#82)
c60e9ad
@stanleyowen stanleyowen added fixed internally Bug has been fixed and ready to be shipped and removed approved Issues have been confirmed by our team labels Sep 14, 2021
@stanleyowen stanleyowen mentioned this issue Sep 15, 2021
Merged
2 tasks
stanleyowen added a commit that referenced this issue Sep 15, 2021
@stanleyowen
Merge pull request #84 from stanleyowen/#82
fd844f3 
Move `switchTab` to child element and Improve Documentation
@stanleyowen stanleyowen mentioned this issue Sep 17, 2021
Merged
@stanleyowen stanleyowen added fixed Bug has been fixed and shipped to production area: production and removed fixed internally Bug has been fixed and ready to be shipped labels Sep 17, 2021
@stanleyowen stanleyowen moved this to Done in Loofi Roadmap Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanleyowen stanleyowen

Labels
area: beta area: production bug Something isn't working fixed Bug has been fixed and shipped to production
Projects
Loofi Roadmap
Status: Done
Milestone
v0.2.5
Development

Successfully merging a pull request may close this issue.

Version 0.2.5 stanleyowen/loofi
1 participant
@stanleyowen