Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Codebase Quality #115

Merged
merged 8 commits into from
Sep 28, 2021
Merged

Improve Codebase Quality #115

merged 8 commits into from
Sep 28, 2021

Conversation

stanleyowen
Copy link
Owner

@stanleyowen stanleyowen commented Sep 28, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Use error attributes instead of secondary for Button
  • Added GENERATE_SOURCEMAP=false Attribute while Building Apps
  • Moved Skeleton Dependency from '@mui/lab' to '@mui/material'
  • Updated Dependencies List
    • Upgrade concurrently Dependency to v6.2.2
    • Upgrade @types/node Dependency to v16.10.1
    • Upgrade @testing-library/react to v12.1.1
    • Deprecated @mui/lab Dependency
    • Fixed Build Issue Across Various OS

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@netlify
Copy link

netlify bot commented Sep 28, 2021 •
edited
Loading

✔️ Deploy Preview for lofi-players ready!

🔨 Explore the source changes: 92a40d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/lofi-players/deploys/6152e385cc929a0008d25f48

😎 Browse the preview: https://deploy-preview-115--lofi-players.netlify.app/

@stanleyowen stanleyowen changed the title Codebase Improve Codebase Quality Sep 28, 2021
@stanleyowen stanleyowen marked this pull request as ready for review September 28, 2021 09:39
@stanleyowen stanleyowen self-assigned this Sep 28, 2021
@stanleyowen stanleyowen added codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) dependencies Issues/pull requests that update a dependency file labels Sep 28, 2021
@stanleyowen stanleyowen added this to the v0.4.5 milestone Sep 28, 2021
@stanleyowen stanleyowen merged commit 7ac254b into next Sep 28, 2021
@stanleyowen stanleyowen deleted the codebase branch September 28, 2021 09:46
@stanleyowen stanleyowen added implemented internally Feature is implemented and ready to be shipped implemented Feature is implemented and shipped to production and removed implemented internally Feature is implemented and ready to be shipped labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees

@stanleyowen stanleyowen

Labels
codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) dependencies Issues/pull requests that update a dependency file implemented Feature is implemented and shipped to production
Projects
Loofi Roadmap
Status: Done
Milestone
v0.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyowen @kimlimjustin