Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase: Improve Performance #79

Merged
merged 11 commits into from
Sep 13, 2021
Merged

Codebase: Improve Performance #79

merged 11 commits into from
Sep 13, 2021

Conversation

stanleyowen
Copy link
Owner

@stanleyowen stanleyowen commented Sep 11, 2021 •
edited
Loading

Details of Changes
Add details of changes here.

  • Move get data function to parent element
  • Clean up unnecessary functions in child component
  • Move config variable directly to child component
  • Updated Dependencies List
    • Upgrade @testing-library/react Dependency to v12.1.0
    • Upgrade typescript Dependency to v4.4.3

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@stanleyowen
Updated Dependencies List
ccec4a8 
Upgrade `@testing-library/react` Dependency to v12.1.0
Upgrade `typescript` Dependency to v4.4.3
@netlify
Copy link

netlify bot commented Sep 11, 2021 •
edited
Loading

✔️ Deploy Preview for lofi-players ready!

🔨 Explore the source changes: a1a518c

🔍 Inspect the deploy log: https://app.netlify.com/sites/lofi-players/deploys/613ed00723185800075473e1

😎 Browse the preview: https://deploy-preview-79--lofi-players.netlify.app/

@stanleyowen stanleyowen self-assigned this Sep 11, 2021
@stanleyowen stanleyowen added the enhancement New feature or request label Sep 11, 2021
@stanleyowen stanleyowen added this to the v0.2.5 milestone Sep 11, 2021
@guardrails
Copy link

guardrails bot commented Sep 12, 2021 •
edited
Loading

⚠️ We detected 1 security issue in this pull request:

Insecure Configuration (1)
Docs Details
💡 Title: Node.js integration enabled (Electron), Severity: Medium
https://github.com/stanleyowen/lofi-player/blob/a1a518c834fd434f617478522bdf935c0fe2183c/public/electron.js#L10

More info on how to fix Insecure Configuration in JavaScript.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@stanleyowen stanleyowen mentioned this pull request Sep 13, 2021
Closed
@stanleyowen stanleyowen marked this pull request as ready for review September 13, 2021 04:24
@stanleyowen stanleyowen merged commit aeca414 into next Sep 13, 2021
@stanleyowen stanleyowen deleted the performance branch September 13, 2021 04:29
@stanleyowen stanleyowen added dependencies Issues/pull requests that update a dependency file codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) implemented internally Feature is implemented and ready to be shipped and removed enhancement New feature or request labels Sep 14, 2021
@stanleyowen stanleyowen mentioned this pull request Sep 17, 2021
Merged
@stanleyowen stanleyowen added implemented Feature is implemented and shipped to production and removed implemented internally Feature is implemented and ready to be shipped labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees

@stanleyowen stanleyowen

Labels
codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) dependencies Issues/pull requests that update a dependency file implemented Feature is implemented and shipped to production
Projects
Loofi Roadmap
Status: Done
Milestone
v0.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyowen @kimlimjustin