Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve App Design #95

Merged
merged 6 commits into from
Sep 20, 2021
Merged

Improve App Design #95

merged 6 commits into from
Sep 20, 2021

Conversation

stanleyowen
Copy link
Owner

@stanleyowen stanleyowen commented Sep 19, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixed Issue of Missing Active Attribute in Active Tab
  • Improved Color Contrast for Active Tab
  • Re-customize App Height
  • Added enterDelay and enterNextDelay props to Tooltip Component
  • Set autocomplete in search field to false
  • Use Slider Component to Replace Input type Range
  • Upgrade @types/node Dependency to v16.9.4

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Improve App Design

@stanleyowen stanleyowen self-assigned this Sep 19, 2021
@netlify
Copy link

netlify bot commented Sep 19, 2021 •
edited
Loading

✔️ Deploy Preview for lofi-players ready!

🔨 Explore the source changes: 2287792

🔍 Inspect the deploy log: https://app.netlify.com/sites/lofi-players/deploys/6148405b660cd900082d962a

😎 Browse the preview: https://deploy-preview-95--lofi-players.netlify.app/

@stanleyowen stanleyowen marked this pull request as ready for review September 20, 2021 08:09
@stanleyowen stanleyowen added the dependencies Issues/pull requests that update a dependency file label Sep 20, 2021
@stanleyowen stanleyowen merged commit c1f48cb into next Sep 20, 2021
@stanleyowen stanleyowen deleted the design branch September 20, 2021 08:14
@stanleyowen stanleyowen mentioned this pull request Sep 23, 2021
Merged
@stanleyowen stanleyowen added the implemented Feature is implemented and shipped to production label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees

@stanleyowen stanleyowen

Labels
dependencies Issues/pull requests that update a dependency file implemented Feature is implemented and shipped to production ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyowen @kimlimjustin