Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pulser correction in production code #335

Merged
merged 34 commits into from
Apr 8, 2022
Merged

Fixing pulser correction in production code #335

Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
30538a0
fixed 64b integer conversion in getField() method and added additiona…
Jun 3, 2021
38d8512
Merge branch 'star-bnl:main' into main
PhilippWeidenkaff Sep 23, 2021
fa8418b
merged with group development to have support for local run-by-run ca…
Oct 4, 2021
5395cb8
merged with group development to have support for local run-by-run ca…
Oct 4, 2021
55bf9ff
<strstring.h> header include needed to be added for local compilation…
Oct 4, 2021
1572c6b
added eTofGoodEventFlag to mark counters which are good foer analysis…
Oct 4, 2021
0e25fc4
moved struct to public to avoid root6 issue. Changed class dev versio…
Oct 6, 2021
d28aaf3
added kStFatal return in ::init if calib histo files are corrupt
Oct 6, 2021
5dbebde
Changed class dev version back to 0
Oct 6, 2021
6681b26
Trying to fix merger
Oct 18, 2021
7519f89
Trying to fix merger
Oct 18, 2021
1e96e9b
added eTofGoodEventFlag to mark counters which are good foer analysis…
Oct 4, 2021
0b1b984
moved struct to public to avoid root6 issue. Changed class dev versio…
Oct 6, 2021
e1dd9b7
added kStFatal return in ::init if calib histo files are corrupt
Oct 6, 2021
8466d72
Changed class dev version back to 0
Oct 6, 2021
b61cbff
decremented classDef version of StEtofCollection. Makers compile corr…
Oct 23, 2021
7c318e0
removed double line in MuEtofHeader constructor
Oct 24, 2021
3c2234c
included eTOF constants header and moved constants here
Oct 24, 2021
29c68fb
included eTOF constants header and moved constants here
Oct 24, 2021
532c054
added constant nbGet4s here for use in event headers
Oct 24, 2021
946d469
recommiting last 3 commits because of merger issue
Oct 25, 2021
7152b45
Removed strstr include in StMuDstMaker.cxx. Now indentical to reposit…
Oct 27, 2021
61250b3
Moved vector init in eTOF headers to initializer list
Oct 27, 2021
c0e8a8e
Changed default reference pulser setting in calib maker back to data …
Oct 29, 2021
7b8f21f
Merge branch 'star-bnl:main' into main
PhilippWeidenkaff Nov 5, 2021
2e76f1e
Moved reference pulser histogram creation outside of doQA flag. Fixin…
Nov 9, 2021
6dcd4ae
Merge branch 'star-bnl:main' into main
PhilippWeidenkaff Nov 11, 2021
8074c65
fixed pulser presence histogram filling in online etofbuilder
Nov 11, 2021
9050850
Merge branch 'star-bnl:main' into main
PhilippWeidenkaff Mar 18, 2022
0fbfa84
Fixed calibmaker pulser correction to work without QA flag online
Mar 24, 2022
0f7aa47
adjustment of nominal eTOF module positions to fit better with data
Mar 24, 2022
a5ff348
Merge branch 'main' into main
plexoos Mar 24, 2022
37d145d
Revert "adjustment of nominal eTOF module positions to fit better wit…
Apr 6, 2022
030c5ff
merged recent changes to remote repo
Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions StRoot/StETofCalibMaker/StETofCalibMaker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,9 +1674,9 @@ StETofCalibMaker::calculatePulserOffsets( std::map< unsigned int, std::vector< u
double referenceTime = 0.;

// update reference time (for QA)
if( pulserTimes.count( mReferencePulserIndex ) ) {
referenceTime = pulserTimes.at( mReferencePulserIndex ); //only updated for QA?? needed to remove smeared pulsers
if( mDoQA ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Philipp, maybe this line can be removed to simplify the code?
Question: does this affect the existing production data? e.g. Run20 FXT datasets which presumably have the ETOF calibrations in.

if( pulserTimes.count( mReferencePulserIndex ) ) {
referenceTime = pulserTimes.at( mReferencePulserIndex ); //only updated for QA?? needed to remove smeared pulsers
if( mDebug ) {
LOG_INFO << "preliminary reference time:" << referenceTime << endm;
}
Expand Down