Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_vertex.C to make ROOT interpreter happy #375

Closed
wants to merge 5 commits into from

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jul 6, 2022

Based on #374 head (7c73863)

@plexoos
Copy link
Member Author

plexoos commented Jul 7, 2022

Ok, fine. But what is the magic behind <StIOMaker::Finish> IO: vs <StIOMaker::Finish> StIO:

@veprbl
Copy link
Member

veprbl commented Jul 7, 2022

Ok, fine. But what is the magic behind <StIOMaker::Finish> IO: vs <StIOMaker::Finish> StIO:

StIOMaker(const char *name="StIO",const char *iomode="r", const char *ioFile="",const char *treeName="bfcTree");

StIOMaker* ioMaker = new StIOMaker();

StIOMaker *IOMk = new StIOMaker("IO","r",setFiles,"bfcTree");

@plexoos
Copy link
Member Author

plexoos commented Jul 7, 2022

This fix will be included in #374

@plexoos plexoos closed this Jul 7, 2022
@veprbl
Copy link
Member

veprbl commented Jul 7, 2022

I'd simply change it to StIOMaker("StIO" for the fix. It's a bit annoying that makers appear with varying names in some chains for no reason.

@plexoos
Copy link
Member Author

plexoos commented Jul 7, 2022

It is absolutely fine by me. Please, by all means, go ahead and make changes as you see fit, just don't make us regret we resurrect macros nobody uses or maintains 😃

@veprbl
Copy link
Member

veprbl commented Jul 7, 2022

Okay, okay :)

@plexoos plexoos deleted the pr/fix_find_vertex_macro branch July 8, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants