-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official centrality calibration for 14.6 GeV Run 19 #384
Conversation
- Add centrality for 14.6 GeV year 2019. - Fix parameter swap for trigger efficiency calculation. - Add Param.cxx (in order to compile in a standalone mode) - Add Makefile to build standalone library (works only with ROOT6)
Hi Grigory, great to see this PR. I am about to send out the announcement for tomorrow's meeting. Will it be possible that you can give a presentation on this PR tomorrow? Thanks |
Hi Xin, are you talking about the S&C meeting? Do I need to prepare slides? |
Yes, Grigory. I think it will be up to you if you see necessary to show a few slides. Thanks |
I think I can say a few words about this PR. |
Rongrong and Dmitri, shall we merge this PR so users can start to use it in their analysis? Thanks |
OK with me. But I think Grigory wants to have Zach involved and go through the procedure. |
Yep, I'm working on validating the changes and am writing some code to compare the expected performance of StRefMultCorr vs its actual performance. I had hoped to finish today, but it looks like it may take one more day. |
I edited a typo in the event-weight parameters that was giving some events a negative weight. I've tested the pileup rejection, Vz correction, and event weights on real data and they all now perform as expected. I sign off. |
Zach, we should merge this PR to the main branch. I am going to reopen it and merge it. |
Official centrality calibration for 14.6 GeV Run19. Also added Makefile for standalone package compilation, which should work with ROOT6 (not with ROOT5 because of CINT).