SpaceCharge distortion corrections for FXT #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this intended for the upcoming SL22c release? |
It is critical for processing the Run 21 FXT data. If not in SL22c now (which is my preference), then we would probably need either an SL22d within a month, or we could have a second version of SL22c as this PR has no impact whatsoever on any existing nor soon-to-be-used chains . Thanks, |
plexoos
reviewed
Sep 8, 2022
plexoos
approved these changes
Sep 8, 2022
genevb
force-pushed
the
FXT_SpaceCharge
branch
from
81a95b0
to
6eb2cd9
Compare
klendathu2k
reviewed
Mar 7, 2023
| void StMagUtilities::UndoSpaceChargeFXTDistortion( const Float_t x[], Float_t Xprime[] , Int_t Sector ) | ||
| { | ||
|
|
||
| const Int_t ORDER = 1 ; // Linear interpolation = 1, Quadratic = 2 |
There was a problem hiding this comment.
per STAR naming conventions, prefer int to Int_t, double to Double_t, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce distortion codes and steering routines to handle SpaceCharge distortions in BES-II FixedTarget data. Includes some very minor re-spacing of code text to keep it looking clean.