[root6] Set attributes on StrangeMuDstMaker in StBFChain, rather than using interpreter to configure #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to a maker, and then call configuration methods. Refactor to use maker attributes, and set configuration options at initialization time.
klendathu2k
requested review from
genevb,
plexoos and
nigmatkulov
as code owners
plexoos
added
the
ROOT6
plexoos
approved these changes
Nov 18, 2022
plexoos
added a commit
to plexoos/star-sw
that referenced
this pull request
Dec 17, 2022
…her than using interpreter to configure (star-bnl#444)" This reverts commit c47c0a6.
plexoos
pushed a commit
to plexoos/star-sw
that referenced
this pull request
Dec 18, 2022
… using interpreter to configure (star-bnl#444) Cling appears to have problems with using ProcessLine to get a pointer to a maker... at least in this context and/or at least in the default environment. So... Refactor to use maker attributes, and set configuration options at initialization time. (This is also cleaner and more inline with the StMaker philosophy).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cling appears to have problems with using ProcessLine to get a pointer to a maker... at least in this context and/or at least in the default environment. So...
Refactor to use maker attributes, and set configuration options at initialization time. (This is also cleaner and more inline with the StMaker philosophy).