Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[root6] Avoid using unnecessary typedefs for TDataSet #483

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

klendathu2k
Copy link
Contributor

@klendathu2k klendathu2k commented Jan 26, 2023

The typedefs aliasing St_DataSet to TDataSet are not required. This prevents us from running some nightly tests which load DB tables which utilize this alias.

Fix error: unknown type name 'St_DataSet' in ROOT6 tests

LoadTable: .L /star-sw/StarDb/tpc/tsspars/tsspar.y2019.C
In file included from input_line_851:1:
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:3:1: error: unknown type name 'St_DataSet'
St_DataSet *CreateTable() {
^
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:57:10: error: use of undeclared identifier 'St_DataSet'
 return (St_DataSet *)tableSet;
         ^
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:57:22: error: expected expression
 return (St_DataSet *)tableSet;
                     ^
root4star: .sl79_gcc485/OBJ/StRoot/St_db_Maker/St_db_Maker.cxx:932: virtual TDataSet* St_db_Maker::LoadTable(TDataSet*): Assertion `!ee' failed.
sh: line 1:   133 Aborted                 (core dumped) MALLOC_CHECK_=3 root4star -b -q -l 'bfc.C(50, "pp2022,StiCA,BEmcChkStat,ftt,-picowrite,-hitfilt,-evout", "/star/rcf/test/daq/2022/040/23040001/st_fwd_23040001_raw_0000003.daq")'
Error: Process completed with exit code 134.

@plexoos plexoos added the ROOT6 Issues and changes related to transition from ROOT5 to ROOT6 label Jan 27, 2023
@plexoos
Copy link
Member

plexoos commented Jan 29, 2023

This is exactly the problem I saw in CI ROOT6 tests. There is an almost identical commit in #452 to deal with this problem fec9c24

I don't see any replies from the respective code owners but the change is transparent so, let's merge.

@plexoos plexoos merged commit e4db2cb into star-bnl:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROOT6 Issues and changes related to transition from ROOT5 to ROOT6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants