Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bfc.C: Call Load() function unconditionally #488

Merged
merged 1 commit into from
Feb 1, 2023
Merged

bfc.C: Call Load() function unconditionally #488

merged 1 commit into from
Feb 1, 2023

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jan 31, 2023

See discussion in #452 #452 (review)

@plexoos plexoos requested a review from genevb as a code owner January 31, 2023 22:04
@plexoos plexoos added the ROOT6 Issues and changes related to transition from ROOT5 to ROOT6 label Jan 31, 2023
@plexoos
Copy link
Member Author

plexoos commented Feb 1, 2023

@genevb Any comments from you? Thank you

genevb
genevb approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genevb Any comments from you? Thank you

I doubt I've thought of anything that you haven't already, @plexoos . If there's no concern about twice-loading (either that it's certain that it won't happen, or that happening is harmless), then I have no objection to loading unconditionally.

@plexoos plexoos merged commit 03d2850 into star-bnl:main Feb 1, 2023
@plexoos plexoos deleted the pr/root6_bfc branch February 1, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb approved these changes

Assignees
No one assigned
Labels
ROOT6 Issues and changes related to transition from ROOT5 to ROOT6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plexoos @genevb