GMT #680

nigmatkulov · 2024-04-10T14:52:18Z

Commit GMT-related classes and macroses. Also, update StarDb/geometry for GMT with the latest alignment.

StRoot/StGmtAligner/EventT.cxx

StRoot/StGmtAligner/EventT.h

klendathu2k

Few suggestions indicated. Few changes should be made,... StGmtAligner should be a maker, and prefer c++ native types (e.g. int) over ROOT types (Int_t) when a class is not intended for IO.

StRoot/StAnalysisMaker/StAnalysisMaker.cxx

StRoot/StEvent/StGmtHit.h

StRoot/StEvent/StGmtPoint.cxx

StRoot/StEvent/StGmtStrip.h

StRoot/StEvent/StGmtStripCollection.h

StRoot/StGmtAligner/StGmtAligner.cxx

StRoot/StGmtAligner/runGmtTree.C

StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx

plexoos

Before I do another round of comments on this massive PR, I would like to see the compiler errors addressed.

StRoot/StEvent/StGmtHit.h

StRoot/StEvent/StGmtHitCollection.cxx

StRoot/StEvent/StGmtPoint.cxx

StRoot/StEvent/StGmtStrip.cxx

StRoot/StEvent/StGmtStripCollection.cxx

StRoot/StGmtAligmentMaker/EventT.h

StRoot/StGmtAligmentMaker/HitT.h

StRoot/StGmtAligmentMaker/StGmtAligner.cxx

fgeurts · 2024-08-21T15:59:19Z

Hi, what is the status of this PR? Have all comments been addressed? If so, can we wrap this one up and prepare this to be merged into the STAR library?

plexoos · 2025-01-22T20:37:11Z

hm... that's interesting:

#10 1435.1 .sl79_gcc485/OBJ/StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx: In member function 'TF1* StGmtClusterMaker::FindPeaks(TH1F*)':
#10 1435.1 .sl79_gcc485/OBJ/StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx:47:38: error: cannot convert 'Double_t* {aka double*}' to 'float*' in initialization
#10 1435.1    float* xpeaks = spect.GetPositionX();

…) method. Try to use auto to avoid problem

nigmatkulov · 2025-01-23T00:29:32Z

hm... that's interesting:

#10 1435.1 .sl79_gcc485/OBJ/StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx: In member function 'TF1* StGmtClusterMaker::FindPeaks(TH1F*)':
#10 1435.1 .sl79_gcc485/OBJ/StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx:47:38: error: cannot convert 'Double_t* {aka double*}' to 'float*' in initialization
#10 1435.1    float* xpeaks = spect.GetPositionX();

The reason is that ROOT5 and ROOT6 use different data types for GetPositionX. I'm trying to overpass it with the auto keyword. Let's see if it will work

StRoot/StBFChain/BigFullChain.h

nigmatkulov · 2025-01-23T15:17:06Z

@plexoos , please take a look at the actions. The current errors are due to the versioning of actions:

Error: This request automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

plexoos · 2025-01-23T15:21:07Z

GitHub is experiencing issues with actions at the moment. You can check the status at https://www.githubstatus.com/

nigmatkulov · 2025-01-23T18:19:23Z

It seems to be fixed by now, but the error persists... I restarted jobs several times with the same result.

plexoos · 2025-01-23T18:32:14Z

#727 should fix this

StRoot/StGmtAlignmentMaker/TrackT.h

StRoot/StEvent/StGmtStrip.cxx

StRoot/StGmtAlignmentMaker/EventT.h

StRoot/StGmtAlignmentMaker/StGmtAlignmentMaker.h

StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx

StRoot/StGmtAlignmentMaker/EventT.cxx

plexoos · 2025-01-29T23:18:54Z

StRoot/StGmtClusterMaker/StGmtClusterMaker.cxx

+  if (Debug()>3) {
+    canv->Divide(2,2);
+
+    canv->cd(1);
+    profX[module]->Draw();
+    canv->cd(2);
+    profY[module]->Draw();
+
+    canv->cd(3);
+    histX->Draw();
+    canv->cd(4);
+    histY->Draw();
+
+    canv->Modified();
+    canv->Update();
+    canv->Draw();
+    if (nClusX || nClusY) {
+      while (!gSystem->ProcessEvents()){gSystem->Sleep(200);}
+    }
+  }


So, if someone wants to debug a different maker by running a BFC chain with GMT options, they’ll have to suffer because you decided to draw histograms and introduce artificial delays...

StRoot/StGmtRawMaker/StGmtRawMaker.h

StarDb added

591afa9

nigmatkulov requested review from genevb, klendathu2k, plexoos, fisyak, R-Witt and iraklic as code owners April 10, 2024 14:52

plexoos reviewed Apr 10, 2024

View reviewed changes

StRoot/StGmtAligner/EventT.cxx Outdated Show resolved Hide resolved

plexoos reviewed Apr 10, 2024

View reviewed changes

StRoot/StGmtAligner/EventT.h Outdated Show resolved Hide resolved

klendathu2k requested changes Apr 11, 2024

View reviewed changes

plexoos requested changes Apr 11, 2024

View reviewed changes

Grigory Nigmatkulov and others added 10 commits May 22, 2024 12:34

Addressing stylish comments

7b302dd

Revert changes due to the inheritance issue

0a15563

Fixing EventT

875a7e4

Moving from the ROOT to C++ type declaration

20dffdf

Update missing parts

b1fb23b

Commenting out unused histo

6ad10c0

Stylish modifications

be2bf1c

Fix typo

b8ebc77

Make preprocessor directive to hide code parts

48a7271

Trying to clean up more

6728fed

plexoos reviewed May 29, 2024

View reviewed changes

nigmatkulov added 7 commits November 27, 2024 09:45

Some updates regardsing the requests

65d159b

Update of char -> const char conversion

8604b50

Reshuffling function definition and remove unused variable

0c37f47

Remoing unused variables from StGmtRawMaker

f4fe3b0

Remove unused variables

03408dd

Merge branch 'main' into GMT

7355aec

More cleanup of StGmtGeom.cxx

ca072bb

nigmatkulov added 2 commits January 22, 2025 16:19

Missed pre-previous commit??

3c99580

ROOT5 and ROOT6 versions use different datatype for the GetPositionX(…

e34f101

…) method. Try to use auto to avoid problem

nigmatkulov added 6 commits January 22, 2025 23:20

Minor stylish updates

e9d4949

Update naming due to grammar mistake

ea63fa1

Fix file names in order those to match class names

369b5f6

Merge branch 'main' into GMT

acf4424

ClassImp was removed from several classes

43ceb66

Missed this one

14c43e5

fisyak approved these changes Jan 23, 2025

View reviewed changes

plexoos reviewed Jan 23, 2025

View reviewed changes

StRoot/StBFChain/BigFullChain.h Outdated Show resolved Hide resolved

nigmatkulov requested review from plexoos and klendathu2k January 23, 2025 14:57

A couple of old (unused) bfc options have been removed

3efd067

plexoos and others added 2 commits January 23, 2025 15:08

Merge branch 'main' into GMT

292b5c0

Resolving old comments

2ddcad8

plexoos requested changes Jan 29, 2025

View reviewed changes

fisyak and others added 6 commits February 1, 2025 11:08

Merge branch 'main' into GMT

0e6a268

Stylish updaste

ab2e838

Dummy typo

1d1ae68

Apply suggestions from code review

badbd95

nitpicking

f2bff93

Merge branch 'main' into GMT

e25b5ae

plexoos merged commit 39e4e4f into main Feb 7, 2025
4 checks passed

plexoos deleted the GMT branch February 7, 2025 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GMT #680

GMT #680

nigmatkulov commented Apr 10, 2024 •

edited

Loading

klendathu2k left a comment

plexoos left a comment

fgeurts commented Aug 21, 2024

plexoos commented Jan 22, 2025

nigmatkulov commented Jan 23, 2025

nigmatkulov commented Jan 23, 2025 •

edited

Loading

plexoos commented Jan 23, 2025

nigmatkulov commented Jan 23, 2025 •

edited

Loading

plexoos commented Jan 23, 2025

plexoos Jan 29, 2025

GMT #680

GMT #680

Conversation

nigmatkulov commented Apr 10, 2024 • edited Loading

klendathu2k left a comment

Choose a reason for hiding this comment

plexoos left a comment

Choose a reason for hiding this comment

fgeurts commented Aug 21, 2024

plexoos commented Jan 22, 2025

nigmatkulov commented Jan 23, 2025

nigmatkulov commented Jan 23, 2025 • edited Loading

plexoos commented Jan 23, 2025

nigmatkulov commented Jan 23, 2025 • edited Loading

plexoos commented Jan 23, 2025

plexoos Jan 29, 2025

Choose a reason for hiding this comment

nigmatkulov commented Apr 10, 2024 •

edited

Loading

nigmatkulov commented Jan 23, 2025 •

edited

Loading

nigmatkulov commented Jan 23, 2025 •

edited

Loading