-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMT #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions indicated. Few changes should be made,... StGmtAligner should be a maker, and prefer c++ native types (e.g. int) over ROOT types (Int_t) when a class is not intended for IO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I do another round of comments on this massive PR, I would like to see the compiler errors addressed.
Hi, what is the status of this PR? Have all comments been addressed? If so, can we wrap this one up and prepare this to be merged into the STAR library? |
hm... that's interesting:
|
…) method. Try to use auto to avoid problem
The reason is that ROOT5 and ROOT6 use different data types for GetPositionX. I'm trying to overpass it with the auto keyword. Let's see if it will work |
@plexoos , please take a look at the actions. The current errors are due to the versioning of actions: Error: This request automatically failed because it uses a deprecated version of |
GitHub is experiencing issues with actions at the moment. You can check the status at https://www.githubstatus.com/ |
#727 should fix this |
if (Debug()>3) { | ||
canv->Divide(2,2); | ||
|
||
canv->cd(1); | ||
profX[module]->Draw(); | ||
canv->cd(2); | ||
profY[module]->Draw(); | ||
|
||
canv->cd(3); | ||
histX->Draw(); | ||
canv->cd(4); | ||
histY->Draw(); | ||
|
||
canv->Modified(); | ||
canv->Update(); | ||
canv->Draw(); | ||
if (nClusX || nClusY) { | ||
while (!gSystem->ProcessEvents()){gSystem->Sleep(200);} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if someone wants to debug a different maker by running a BFC chain with GMT options, they’ll have to suffer because you decided to draw histograms and introduce artificial delays...
Commit GMT-related classes and macroses. Also, update StarDb/geometry for GMT with the latest alignment.