Simplify get_tables_by_pattern_sql #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesmet
force-pushed
the
bug/get_tables_by_pattern
branch
from
3add689 to
243299a
Compare
mdesmet
force-pushed
the
bug/get_tables_by_pattern
branch
from
243299a to
abc969b
Compare
mdesmet
changed the title
damian3031
approved these changes
Dec 19, 2022
hovaesco
reviewed
Dec 19, 2022
| @@ -11,8 +11,7 @@ RUN apt-get update && \ | |||
| apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/ | |||
| RUN pip3 install --upgrade pip | |||
| RUN mkdir ${DBT_DIR} | |||
| # TODO: change with release version | |||
| RUN pip install git+https://github.com/starburstdata/dbt-trino.git | |||
| RUN pip install dbt-trino==1.3 | |||
There was a problem hiding this comment.
Oops, too fast. This is indeed not working as expected.
It seems however that RUN pip install dbt-trino==1.3.* also works.
There was a problem hiding this comment.
~= will always install the latest version compatible with the pattern.
== won't update to the newest version if the older version which matches the pattern is already installed.
So I think ~= is slightly better here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.