Upgrade dbt-utils #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about #4? Should it be closed? |
mdesmet
force-pushed
the
bug/fix-adapter-macros
branch
2 times, most recently
from
5648dc3 to
d8d6f43
Compare
mdesmet
force-pushed
the
bug/fix-adapter-macros
branch
from
d8d6f43 to
4f513f6
Compare
mdesmet
commented
Oct 5, 2022
docker/dbt/Dockerfile
Outdated
| # TODO: change with release version | ||
| RUN pip install git+https://github.com/starburstdata/dbt-trino.git | ||
| # TODO: change with release version once PR is merged | ||
| RUN pip3 install git+https://github.com/mdesmet/dbt-trino.git@feature/get_colums_in_relation |
There was a problem hiding this comment.
This should be changed after we merge that branch on dbt-trino
hovaesco
approved these changes
Oct 5, 2022
macros/dbt_utils/sql/date_spine.sql
Outdated
|
|
||
| select * from filtered | ||
|
|
||
| {% endmacro %} |
There was a problem hiding this comment.
nit: new line here and in other places
| {% macro trino__date_spine(datepart, start_date, end_date) %} | ||
|
|
||
|
|
||
| {# call as follows: |
There was a problem hiding this comment.
it comes from the original dbt implementation, I would say it's ok to keep it.
| {%- macro trino__deduplicate(relation, partition_by, order_by) -%} | ||
| {# | ||
| -- This is a temporary solution until https://github.com/trinodb/trino/issues/14455 is resolved | ||
| -- It leaks the rn column compared to the NATURAL JOIN solution from dbt |
There was a problem hiding this comment.
So the NATURAL JOIN implementation (which is not supported) would not leak the row number column as output of the deduplicate query.
mdesmet
force-pushed
the
bug/fix-adapter-macros
branch
2 times, most recently
from
ce00d7f to
24836a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.