Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323

Conversation

Thelin90
Copy link

@Thelin90 Thelin90 commented Jul 12, 2023

Overview

resolves #322

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@Thelin90 Thelin90 force-pushed the enhancement-322-Add-retry-mechanism-for-the-given-error branch from 14557b0 to 6929e02 Compare July 12, 2023 14:11
sql: str,
auto_begin: bool = False,
fetch: bool = False,
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trino.constants.DEFAULT_MAX_ATTEMPTS is for connection timeout issues

auto_begin: bool = False,
fetch: bool = False,
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS,
retry_delay: int = 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dataders can we pass a specific error message, retry_delay and max_retries from model configuration to here?

@SoumayaMauthoorMOJ
Copy link

I have created a dbt-core issue that is probably relevant: dbt-labs/dbt-adapters#226

@hovaesco hovaesco closed this Jul 29, 2024
@mattiamatrix
Copy link

Hello, why was this closed? I think it's still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retry mechanism for the given error
4 participants