Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accumulator] Fix accumulator get_leaves return order and append result. #1581

Merged
merged 3 commits into from
Nov 4, 2020
Merged

[accumulator] Fix accumulator get_leaves return order and append result. #1581

merged 3 commits into from
Nov 4, 2020

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Nov 3, 2020

  1. Accumulator get_leaves return reverse order when get with reverse = true.
  2. Remove leaf_index from Accumulator append return result, only return root_hash.

@jolestar
[accumulator] Fix accumulator get_leaves return order and append result.
6e8c239 
1. Accumulator get_leaves return reverse order when get with reverse = true.
2. Remove leaf_index from Accumulator append return result, only return root_hash.

accumulator] Fix accumulator append result.
@aviator-app aviator-app bot merged commit b5d9f70 into master Nov 4, 2020
@aviator-app aviator-app bot deleted the fix/accumulator branch November 4, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssyuan ssyuan ssyuan approved these changes

@tiangong3624749 tiangong3624749 Awaiting requested review from tiangong3624749

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolestar @ssyuan