Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib & cmd]Stdlib Version #1603

Merged
merged 13 commits into from
Nov 10, 2020
Merged

[stdlib & cmd]Stdlib Version #1603

merged 13 commits into from
Nov 10, 2020

Conversation

tiangong3624749
Copy link
Contributor

  1. version不再dao托管
  2. TwoPhaseUpgrade增加version和event
  3. 提交proposal指定version
  4. 去掉proposal和package当前用户的限制，删掉ModuleMaintainer
  5. upgrade module cmd

This was linked to issues Nov 7, 2020
stdlib upgrade and version update #1540
Closed
stdlib upgrade event. #1529
Closed
@tiangong3624749 tiangong3624749 added the break Issue will break blockchain's compatibility label Nov 7, 2020
jolestar
jolestar reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdlib version 是不是也需要改成一个版本号的？genesis 初始化后时，需要把 stdlib 版本号传进来，然后写到 version 里。

cmd/starcoin/src/dev/upgrade_module_exe_cmd.rs Outdated Show resolved Hide resolved
cmd/starcoin/src/dev/sign_txn_helper.rs Show resolved Hide resolved
cmd/starcoin/src/dev/upgrade_module_proposal_cmd.rs Outdated Show resolved Hide resolved
vm/stdlib/modules/PackageTxnManager.move Outdated Show resolved Hide resolved
vm/stdlib/modules/PackageTxnManager.move Outdated Show resolved Hide resolved
vm/stdlib/modules/PackageTxnManager.move Outdated Show resolved Hide resolved
@tiangong3624749 tiangong3624749 linked an issue Nov 9, 2020 that may be closed by this pull request
check compatibility with a previous released stdlib version. #1530
Closed
@aviator-app aviator-app bot merged commit a88e89a into master Nov 10, 2020
@aviator-app aviator-app bot deleted the version branch November 10, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

@nanne007 nanne007 Awaiting requested review from nanne007

Assignees
No one assigned
Labels
break Issue will break blockchain's compatibility
Projects
None yet
Milestone
No milestone
3 participants
@tiangong3624749 @jolestar @nanne007