Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] add command to show tps for given epoch #1617

Merged
merged 10 commits into from
Nov 13, 2020
Merged

[cli] add command to show tps for given epoch #1617

merged 10 commits into from
Nov 13, 2020

Conversation

guangyuz
Copy link
Contributor

No description provided.

@guangyuz guangyuz changed the title [cmd] add command to show tps for given epoch [cli] add command to show tps for given epoch Nov 10, 2020
jolestar
jolestar reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉可以把 get_epoch_info_by_number 的 number 改成 epoch 的 number。这样可能好理解一些，原来就想改来着。不过那样得通过 epoch number 推断一下 epoch 的 block_number。

chain/src/chain.rs Outdated Show resolved Hide resolved
chain/src/chain.rs Outdated Show resolved Hide resolved
cmd/starcoin/src/chain/get_tps.rs Outdated Show resolved Hide resolved
cmd/starcoin/src/chain/get_tps.rs Outdated Show resolved Hide resolved
cmd/starcoin/src/chain/get_tps.rs Outdated Show resolved Hide resolved
@guangyuz guangyuz requested a review from jolestar November 11, 2020 13:34
@jolestar jolestar merged commit 792759b into master Nov 13, 2020
@jolestar jolestar deleted the tps branch November 13, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guangyuz @jolestar