Unify json api #1673
Merged
Unify json api #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanne007
force-pushed
the
unify-json-api
branch
2 times, most recently
from
65730b3 to
f20b225
Compare
|
sip link: starcoinorg/sips#1 |
nanne007
force-pushed
the
unify-json-api
branch
from
f20b225 to
80167d2
Compare
|
在 SIP 的基础上，加了 获取 chain id 的接口。 |
jolestar
approved these changes
Nov 26, 2020
Comment on lines
+68
to
+96
| // pub struct BlockHeaderView { | ||
| // pub parent_hash: HashValue, | ||
| // pub number: u64, | ||
| // pub id: HashValue, | ||
| // pub author: AccountAddress, | ||
| // pub accumulator_root: HashValue, | ||
| // pub state_root: HashValue, | ||
| // pub gas_used: u64, | ||
| // pub time: u64, | ||
| // } | ||
| // | ||
| // impl From<Block> for BlockHeaderView { | ||
| // fn from(block: Block) -> Self { | ||
| // BlockHeaderView::from(block.header) | ||
| // } | ||
| // } | ||
| // | ||
| // impl From<BlockHeader> for BlockHeaderView { | ||
| // fn from(header: BlockHeader) -> Self { | ||
| // Self { | ||
| // parent_hash: header.parent_hash, | ||
| // number: header.number, | ||
| // id: header.id(), | ||
| // author: header.author, | ||
| // accumulator_root: header.accumulator_root, | ||
| // state_root: header.state_root, | ||
| // gas_used: header.gas_used, | ||
| // time: header.timestamp, | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change json api to adopt new api types.