Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] Refactor network handshake message #1714

Merged
merged 1 commit into from
Nov 27, 2020
Merged

[network] Refactor network handshake message #1714

merged 1 commit into from
Nov 27, 2020

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Nov 27, 2020 •
edited
Loading

  1. Refactor PeerInfo, ChainInfo, ChainStatus, network Status handshake message.
  2. Move chain_id from node to chain.
  3. Rename chain show command to chain info

@jolestar jolestar changed the title [network] network handshake message [network] Refactor network handshake message Nov 27, 2020
tiangong3624749
tiangong3624749 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@tiangong3624749 tiangong3624749 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar merged commit 31200fb into master Nov 27, 2020
@jolestar jolestar deleted the feature/network_handshake2 branch November 27, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangong3624749 tiangong3624749 tiangong3624749 approved these changes

@nanne007 nanne007 nanne007 approved these changes

@fanngyuan fanngyuan Awaiting requested review from fanngyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolestar @nanne007 @tiangong3624749