Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] Refactor PeerMessage #1726

Merged
merged 3 commits into from
Dec 1, 2020
Merged

[network] Refactor PeerMessage #1726

merged 3 commits into from
Dec 1, 2020

Conversation

jolestar
Copy link
Member

  1. Decode PeerMessage by protocol name.
  2. Network api provider broadcast function.
  3. Cleanup unneeded message and crate(tx-relay and block-relayer-api).

@jolestar jolestar force-pushed the feature/network_peer_message branch 3 times, most recently from 2a78f19 to a6acb94 Compare December 1, 2020 08:19
tiangong3624749
tiangong3624749 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@tiangong3624749 tiangong3624749 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar force-pushed the feature/network_peer_message branch from d76f9cb to baf836e Compare December 1, 2020 10:03
@jolestar
[network] Refactor PeerMessage
000f401 
1. Decode PeerMessage by protocol name.
2. Network api provider broadcast function.
3. Cleanup unneeded message and crate(tx-relay and block-relayer-api).
@jolestar
[sync] Add a test for test sync by notification message.
b4a1ede
@jolestar
[network] Spawn network worker future when service run, and use memor…
d39399a 
…y transport in test.
@jolestar jolestar force-pushed the feature/network_peer_message branch from baf836e to d39399a Compare December 1, 2020 11:10
@jolestar jolestar merged commit 2b9f5c5 into master Dec 1, 2020
@jolestar jolestar deleted the feature/network_peer_message branch December 1, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangong3624749 tiangong3624749 tiangong3624749 approved these changes

@sanlee42 sanlee42 sanlee42 approved these changes

@nanne007 nanne007 nanne007 approved these changes

@fanngyuan fanngyuan Awaiting requested review from fanngyuan

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolestar @nanne007 @sanlee42 @tiangong3624749