Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: make rpc api configurable #1750

Merged
merged 2 commits into from
Dec 3, 2020
Merged

config: make rpc api configurable #1750

merged 2 commits into from
Dec 3, 2020

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Dec 3, 2020

No description provided.

jolestar
jolestar approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/src/rpc_config.rs
}

#[derive(Debug, Clone, PartialEq, Deserialize, Serialize, StructOpt)]
pub struct WsConfiguration {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个方式不错，是不是我们所有的 Cli Option 以及 Config 都可以考虑用这种方式统一一下。

@nanne007 nanne007 changed the title [WIP] config: make rpc api configurable config: make rpc api configurable Dec 3, 2020
@tiangong3624749 tiangong3624749 merged commit 2433156 into master Dec 3, 2020
@tiangong3624749 tiangong3624749 deleted the rpc-config branch December 3, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanne007 @jolestar @tiangong3624749