Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd & scmd] Pass version/long version by args and fix git version. #1878

Merged
merged 2 commits into from
Dec 25, 2020
Merged

[cmd & scmd] Pass version/long version by args and fix git version. #1878

merged 2 commits into from
Dec 25, 2020

Conversation

jolestar
Copy link
Member

  1. Version 作为参数传递，scmd 不在自动生成 version。
  2. 增加参数，让 git_version 可以正确获取到最新的 git tag。

@jolestar jolestar requested review from ssyuan and nanne007 December 24, 2020 11:35
@jolestar jolestar merged commit c235ecd into master Dec 25, 2020
@jolestar jolestar deleted the fix/cmd_version branch December 25, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanne007 nanne007 nanne007 approved these changes

@ssyuan ssyuan Awaiting requested review from ssyuan

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolestar @nanne007