Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/config refactor #1925

Merged
merged 12 commits into from
Jan 8, 2021
Merged

Feature/config refactor #1925

merged 12 commits into from
Jan 8, 2021

Conversation

ssyuan
Copy link
Member

@ssyuan ssyuan commented Jan 6, 2021

1、config命令行、文件同步
2、config配置优化，StructOpt封装

@ssyuan ssyuan requested review from jolestar and nanne007 and removed request for jolestar January 6, 2021 02:39
@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #1925 (ad2145a) into master (399a725) will increase coverage by 0.09%.
The diff coverage is 41.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
+ Coverage   34.10%   34.19%   +0.09%     
==========================================
  Files         454      455       +1     
  Lines       39240    39347     +107     
  Branches    17474    17497      +23     
==========================================
+ Hits        13379    13449      +70     
- Misses      12560    12588      +28     
- Partials    13301    13310       +9
Flag Coverage Δ
unittests 34.19% <41.43%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/miner_client/src/cpu_solver.rs 25.72% <0.00%> (-1.42%) ⬇️
config/src/account_vault_config.rs 65.00% <0.00%> (-7.22%) ⬇️
config/src/lib.rs 31.58% <0.00%> (+0.99%) ⬆️
config/src/storage_config.rs 53.13% <0.00%> (-9.83%) ⬇️
miner/src/generate_block_event_pacemaker.rs 41.87% <0.00%> (ø)
miner/src/lib.rs 37.50% <0.00%> (-0.47%) ⬇️
network/src/worker.rs 33.34% <0.00%> (-1.51%) ⬇️
node/src/node.rs 15.50% <0.00%> (ø)
config/src/sync_config.rs 24.25% <11.12%> (+6.47%) ⬆️
config/src/txpool_config.rs 42.11% <33.34%> (-7.89%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399a725...ad2145a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Benchmark for e208b0e

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1465.2±63.07µs 1423.6±79.62µs +2.92%
block_apply/block_apply_10 389.5±0.94ms 389.2±2.15ms +0.08%
block_apply/block_apply_1000 40.6±0.16s 40.0±0.79s +1.50%
get_with_proof/db_store 44.8±1.04µs 44.2±0.92µs +1.36%
get_with_proof/mem_store 34.5±0.75µs 34.6±0.95µs -0.29%
put_and_commit/db_store/1 693.8±75.08µs 693.6±32.12µs +0.03%
put_and_commit/db_store/10 1737.7±211.18µs 1886.4±1063.68µs -7.88%
put_and_commit/db_store/100 9.9±0.57ms 9.9±0.72ms 0.00%
put_and_commit/db_store/5 1184.8±218.04µs 1205.2±198.30µs -1.69%
put_and_commit/db_store/50 5.6±0.49ms 5.6±0.39ms 0.00%
put_and_commit/mem_store/1 75.7±3.87µs 77.1±4.25µs -1.82%
put_and_commit/mem_store/10 675.1±32.73µs 682.7±36.72µs -1.11%
put_and_commit/mem_store/100 6.3±0.24ms 6.3±0.30ms 0.00%
put_and_commit/mem_store/5 348.4±18.23µs 350.0±16.99µs -0.46%
put_and_commit/mem_store/50 3.2±0.12ms 3.2±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 1280.3±10.16µs 1255.5±8.94µs +1.98%
query_block/query_block_in(10)_times(1000) 13.0±0.06ms 12.6±0.10ms +3.17%
query_block/query_block_in(10)_times(10000) 129.8±0.83ms 125.6±0.68ms +3.34%
query_block/query_block_in(1000)_times(100) 1231.5±11.64µs 1179.1±9.15µs +4.44%
query_block/query_block_in(1000)_times(1000) 12.4±0.04ms 11.8±0.07ms +5.08%
query_block/query_block_in(1000)_times(10000) 124.9±0.85ms 118.4±0.90ms +5.49%
storage_transaction 18.6±0.74ms 16.8±0.85ms +10.71%
vm/transaction_execution/1 352.5±2.89ms 353.5±3.53ms -0.28%
vm/transaction_execution/10 111.5±1.04ms 110.8±1.27ms +0.63%
vm/transaction_execution/20 104.2±0.95ms 104.3±0.99ms -0.10%
vm/transaction_execution/5 135.0±0.72ms 136.5±0.79ms -1.10%
vm/transaction_execution/50 120.6±1.04ms 120.8±1.43ms -0.17%

jolestar
jolestar reviewed Jan 6, 2021
View reviewed changes
config/src/miner_config.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Benchmark for 89e5f42

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1442.1±131.21µs 1355.9±105.55µs +6.36%
block_apply/block_apply_10 350.6±4.10ms 353.6±5.11ms -0.85%
block_apply/block_apply_1000 36.6±0.55s 37.5±0.33s -2.40%
get_with_proof/db_store 44.4±0.25µs 45.9±0.46µs -3.27%
get_with_proof/mem_store 34.7±0.25µs 35.4±0.36µs -1.98%
put_and_commit/db_store/1 702.4±79.90µs 631.3±115.51µs +11.26%
put_and_commit/db_store/10 1884.1±485.83µs 1960.2±608.15µs -3.88%
put_and_commit/db_store/100 10.7±1.52ms 10.7±1.79ms 0.00%
put_and_commit/db_store/5 1255.4±485.58µs 1193.6±447.06µs +5.18%
put_and_commit/db_store/50 5.9±0.91ms 6.1±1.13ms -3.28%
put_and_commit/mem_store/1 76.8±3.79µs 76.7±3.71µs +0.13%
put_and_commit/mem_store/10 684.2±30.70µs 683.9±31.34µs +0.04%
put_and_commit/mem_store/100 6.3±0.20ms 6.3±0.20ms 0.00%
put_and_commit/mem_store/5 351.6±17.71µs 351.8±17.14µs -0.06%
put_and_commit/mem_store/50 3.2±0.12ms 3.2±0.11ms 0.00%
query_block/query_block_in(10)_times(100) 1194.9±6.80µs 1219.0±7.47µs -1.98%
query_block/query_block_in(10)_times(1000) 12.0±0.10ms 12.2±0.07ms -1.64%
query_block/query_block_in(10)_times(10000) 120.5±0.55ms 122.9±0.84ms -1.95%
query_block/query_block_in(1000)_times(100) 1167.0±12.15µs 1190.5±2.24µs -1.97%
query_block/query_block_in(1000)_times(1000) 11.6±0.09ms 11.9±0.03ms -2.52%
query_block/query_block_in(1000)_times(10000) 115.2±0.60ms 119.9±0.82ms -3.92%
storage_transaction 18.2±1.08ms 17.2±1.21ms +5.81%
vm/transaction_execution/1 349.2±0.70ms 351.6±0.49ms -0.68%
vm/transaction_execution/10 111.0±1.22ms 111.4±0.23ms -0.36%
vm/transaction_execution/20 104.4±1.50ms 104.1±0.29ms +0.29%
vm/transaction_execution/5 135.4±0.67ms 135.7±0.41ms -0.22%
vm/transaction_execution/50 119.9±0.14ms 120.8±0.43ms -0.75%

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Benchmark for 4262209

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1492.7±311.21µs 1492.6±523.17µs +0.01%
block_apply/block_apply_10 390.9±2.58ms 386.5±2.27ms +1.14%
block_apply/block_apply_1000 40.9±0.17s 40.8±0.09s +0.25%
get_with_proof/db_store 44.9±1.25µs 44.8±0.76µs +0.22%
get_with_proof/mem_store 35.1±1.06µs 35.1±0.57µs 0.00%
put_and_commit/db_store/1 683.2±29.16µs 675.2±28.52µs +1.18%
put_and_commit/db_store/10 1873.2±717.85µs 1755.9±197.36µs +6.68%
put_and_commit/db_store/100 10.2±0.70ms 9.8±0.69ms +4.08%
put_and_commit/db_store/5 1217.4±184.80µs 1166.2±200.17µs +4.39%
put_and_commit/db_store/50 5.8±0.40ms 5.5±0.40ms +5.45%
put_and_commit/mem_store/1 76.9±5.59µs 76.4±4.15µs +0.65%
put_and_commit/mem_store/10 696.6±32.00µs 679.6±35.95µs +2.50%
put_and_commit/mem_store/100 6.4±0.27ms 6.1±0.27ms +4.92%
put_and_commit/mem_store/5 350.6±22.82µs 345.4±19.57µs +1.51%
put_and_commit/mem_store/50 3.2±0.21ms 3.2±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 1219.3±4.39µs 1238.7±11.44µs -1.57%
query_block/query_block_in(10)_times(1000) 12.4±0.14ms 12.4±0.07ms 0.00%
query_block/query_block_in(10)_times(10000) 122.4±1.03ms 126.7±1.11ms -3.39%
query_block/query_block_in(1000)_times(100) 1198.1±8.95µs 1162.9±20.91µs +3.03%
query_block/query_block_in(1000)_times(1000) 11.8±0.15ms 11.5±0.08ms +2.61%
query_block/query_block_in(1000)_times(10000) 119.5±1.37ms 115.8±0.94ms +3.20%
storage_transaction 19.1±6.38ms 18.4±0.59ms +3.80%
vm/transaction_execution/1 344.0±2.82ms 342.6±4.90ms +0.41%
vm/transaction_execution/10 107.1±1.69ms 107.3±0.98ms -0.19%
vm/transaction_execution/20 100.9±2.83ms 100.0±1.79ms +0.90%
vm/transaction_execution/5 132.1±0.91ms 131.4±1.77ms +0.53%
vm/transaction_execution/50 115.0±1.72ms 114.1±1.74ms +0.79%

@ssyuan ssyuan linked an issue Jan 6, 2021 that may be closed by this pull request
Cleanup Config #1813
Closed
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Benchmark for c22bc12

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1505.8±57.20µs 1494.9±72.66µs +0.73%
block_apply/block_apply_10 393.5±2.13ms 396.0±5.86ms -0.63%
block_apply/block_apply_1000 41.4±0.11s 41.1±0.31s +0.73%
get_with_proof/db_store 46.4±0.97µs 46.7±1.43µs -0.64%
get_with_proof/mem_store 35.9±0.77µs 36.7±0.90µs -2.18%
put_and_commit/db_store/1 718.1±92.04µs 705.5±73.45µs +1.79%
put_and_commit/db_store/10 1818.8±206.62µs 1820.4±236.59µs -0.09%
put_and_commit/db_store/100 10.2±0.60ms 10.4±0.65ms -1.92%
put_and_commit/db_store/5 1240.1±193.25µs 1214.1±181.37µs +2.14%
put_and_commit/db_store/50 5.9±0.52ms 5.8±0.36ms +1.72%
put_and_commit/mem_store/1 79.1±4.31µs 79.8±4.21µs -0.88%
put_and_commit/mem_store/10 697.6±31.68µs 695.4±31.92µs +0.32%
put_and_commit/mem_store/100 6.4±0.24ms 6.5±0.33ms -1.54%
put_and_commit/mem_store/5 358.8±18.25µs 362.0±18.07µs -0.88%
put_and_commit/mem_store/50 3.3±0.13ms 3.3±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 1256.1±3.68µs 1254.6±13.99µs +0.12%
query_block/query_block_in(10)_times(1000) 12.6±0.19ms 12.6±0.07ms 0.00%
query_block/query_block_in(10)_times(10000) 125.5±0.72ms 125.6±0.74ms -0.08%
query_block/query_block_in(1000)_times(100) 1224.7±3.75µs 1240.6±7.96µs -1.28%
query_block/query_block_in(1000)_times(1000) 12.3±0.07ms 12.4±0.09ms -0.81%
query_block/query_block_in(1000)_times(10000) 122.1±0.54ms 124.7±0.62ms -2.09%
storage_transaction 20.6±6.39ms 20.0±6.27ms +3.00%
vm/transaction_execution/1 352.3±2.21ms 352.0±1.77ms +0.09%
vm/transaction_execution/10 111.2±1.13ms 110.7±1.09ms +0.45%
vm/transaction_execution/20 103.7±0.99ms 103.4±1.37ms +0.29%
vm/transaction_execution/5 136.0±0.89ms 134.3±0.59ms +1.27%
vm/transaction_execution/50 119.0±0.61ms 118.7±0.60ms +0.25%

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Benchmark for 63b7991

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1419.8±131.83µs 1572.7±1654.22µs -9.72%
block_apply/block_apply_10 367.2±19.09ms 353.9±8.29ms +3.76%
block_apply/block_apply_1000 37.2±0.41s 37.1±0.34s +0.27%
get_with_proof/db_store 46.1±0.39µs 44.0±0.61µs +4.77%
get_with_proof/mem_store 36.5±0.41µs 35.6±0.70µs +2.53%
put_and_commit/db_store/1 609.9±106.76µs 654.3±115.36µs -6.79%
put_and_commit/db_store/10 1951.6±783.72µs 2.0±0.70ms -2.42%
put_and_commit/db_store/100 10.8±2.46ms 11.0±2.21ms -1.82%
put_and_commit/db_store/5 1278.1±641.37µs 1347.9±616.73µs -5.18%
put_and_commit/db_store/50 6.3±1.54ms 6.2±1.50ms +1.61%
put_and_commit/mem_store/1 76.2±3.68µs 76.9±4.06µs -0.91%
put_and_commit/mem_store/10 688.2±29.63µs 685.0±30.22µs +0.47%
put_and_commit/mem_store/100 6.3±0.28ms 6.3±0.25ms 0.00%
put_and_commit/mem_store/5 349.3±16.63µs 348.4±17.83µs +0.26%
put_and_commit/mem_store/50 3.2±0.15ms 3.2±0.15ms 0.00%
query_block/query_block_in(10)_times(100) 1204.5±4.73µs 1231.5±10.60µs -2.19%
query_block/query_block_in(10)_times(1000) 12.2±0.07ms 12.3±0.07ms -0.81%
query_block/query_block_in(10)_times(10000) 122.1±0.65ms 123.0±0.80ms -0.73%
query_block/query_block_in(1000)_times(100) 1180.7±1.13µs 1197.3±2.19µs -1.39%
query_block/query_block_in(1000)_times(1000) 11.8±0.02ms 12.3±0.04ms -4.07%
query_block/query_block_in(1000)_times(10000) 118.0±0.22ms 119.9±0.15ms -1.58%
storage_transaction 15.6±1.38ms 15.9±4.15ms -1.89%
vm/transaction_execution/1 345.7±1.72ms 345.4±1.05ms +0.09%
vm/transaction_execution/10 109.7±1.66ms 108.7±0.93ms +0.92%
vm/transaction_execution/20 101.0±0.35ms 101.8±0.67ms -0.79%
vm/transaction_execution/5 132.5±0.48ms 131.9±0.98ms +0.45%
vm/transaction_execution/50 116.8±0.65ms 116.8±0.58ms 0.00%

jolestar
jolestar reviewed Jan 7, 2021
View reviewed changes
config/src/lib.rs Outdated Show resolved Hide resolved
config/src/lib.rs Outdated Show resolved Hide resolved
@nanne007 nanne007 mentioned this pull request Jan 7, 2021
Merged
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Benchmark for e8cc0e7

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1396.6±83.17µs 1383.6±78.40µs +0.94%
block_apply/block_apply_10 353.1±5.68ms 355.7±3.35ms -0.73%
block_apply/block_apply_1000 36.8±0.41s 37.7±0.22s -2.39%
get_with_proof/db_store 46.1±0.46µs 45.7±1.85µs +0.88%
get_with_proof/mem_store 35.7±0.49µs 36.0±0.43µs -0.83%
put_and_commit/db_store/1 678.3±122.81µs 620.1±66.81µs +9.39%
put_and_commit/db_store/10 1839.5±644.85µs 1778.7±498.29µs +3.42%
put_and_commit/db_store/100 11.5±3.05ms 11.2±3.25ms +2.68%
put_and_commit/db_store/5 1223.5±393.23µs 1252.2±485.65µs -2.29%
put_and_commit/db_store/50 6.3±0.96ms 6.1±0.92ms +3.28%
put_and_commit/mem_store/1 78.6±3.68µs 79.7±3.99µs -1.38%
put_and_commit/mem_store/10 707.7±30.59µs 699.3±30.57µs +1.20%
put_and_commit/mem_store/100 6.5±0.23ms 6.5±0.26ms 0.00%
put_and_commit/mem_store/5 363.7±18.76µs 357.2±18.73µs +1.82%
put_and_commit/mem_store/50 3.3±0.16ms 3.3±0.16ms 0.00%
query_block/query_block_in(10)_times(100) 1214.1±11.46µs 1241.6±11.01µs -2.21%
query_block/query_block_in(10)_times(1000) 12.0±0.08ms 12.4±0.09ms -3.23%
query_block/query_block_in(10)_times(10000) 120.2±0.89ms 125.6±0.66ms -4.30%
query_block/query_block_in(1000)_times(100) 1145.9±1.71µs 1231.0±2.00µs -6.91%
query_block/query_block_in(1000)_times(1000) 11.4±0.02ms 12.3±0.10ms -7.32%
query_block/query_block_in(1000)_times(10000) 114.8±0.47ms 121.7±0.19ms -5.67%
storage_transaction 16.1±0.72ms 17.4±0.91ms -7.47%
vm/transaction_execution/1 348.2±1.12ms 346.1±0.75ms +0.61%
vm/transaction_execution/10 109.9±0.17ms 109.4±0.98ms +0.46%
vm/transaction_execution/20 103.2±0.75ms 102.4±0.92ms +0.78%
vm/transaction_execution/5 134.4±0.34ms 133.2±0.74ms +0.90%
vm/transaction_execution/50 118.5±0.76ms 116.8±0.57ms +1.46%

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Benchmark for aa2009b

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1495.4±75.08µs 1530.3±93.86µs -2.28%
block_apply/block_apply_10 388.9±2.85ms 399.1±28.36ms -2.56%
block_apply/block_apply_1000 41.0±0.09s 40.9±0.11s +0.24%
get_with_proof/db_store 45.5±1.02µs 44.3±0.72µs +2.71%
get_with_proof/mem_store 35.6±0.76µs 35.3±1.02µs +0.85%
put_and_commit/db_store/1 724.0±47.95µs 716.4±26.35µs +1.06%
put_and_commit/db_store/10 1816.4±174.62µs 1851.6±184.67µs -1.90%
put_and_commit/db_store/100 10.0±0.70ms 10.1±0.71ms -0.99%
put_and_commit/db_store/5 1240.9±157.30µs 1219.3±120.57µs +1.77%
put_and_commit/db_store/50 5.6±0.41ms 5.7±0.38ms -1.75%
put_and_commit/mem_store/1 77.2±4.03µs 77.0±4.15µs +0.26%
put_and_commit/mem_store/10 682.0±33.55µs 680.4±35.13µs +0.24%
put_and_commit/mem_store/100 6.2±0.22ms 6.3±0.35ms -1.59%
put_and_commit/mem_store/5 350.2±18.64µs 346.6±19.18µs +1.04%
put_and_commit/mem_store/50 3.2±0.16ms 3.2±0.13ms 0.00%
query_block/query_block_in(10)_times(100) 1234.7±10.07µs 1271.2±7.83µs -2.87%
query_block/query_block_in(10)_times(1000) 12.5±0.10ms 12.8±0.14ms -2.34%
query_block/query_block_in(10)_times(10000) 124.2±0.68ms 128.5±1.28ms -3.35%
query_block/query_block_in(1000)_times(100) 1211.9±11.31µs 1219.6±5.22µs -0.63%
query_block/query_block_in(1000)_times(1000) 12.1±0.05ms 12.1±0.09ms 0.00%
query_block/query_block_in(1000)_times(10000) 119.4±1.79ms 120.7±0.57ms -1.08%
storage_transaction 19.5±0.63ms 19.6±0.57ms -0.51%
vm/transaction_execution/1 353.3±2.55ms 350.3±2.29ms +0.86%
vm/transaction_execution/10 109.9±0.87ms 110.8±2.49ms -0.81%
vm/transaction_execution/20 101.9±1.19ms 100.7±0.87ms +1.19%
vm/transaction_execution/5 135.0±1.42ms 133.7±1.23ms +0.97%
vm/transaction_execution/50 117.1±1.25ms 116.6±1.39ms +0.43%

@ssyuan ssyuan requested a review from guangyuz January 8, 2021 05:58
@jolestar
Copy link
Member

jolestar commented Jan 8, 2021

需要确认下命令行参数修改是否需要同时修改 halley 的部署脚本。

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Benchmark for 320c4f0

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1512.7±128.59µs 1500.2±63.40µs +0.83%
block_apply/block_apply_10 393.6±1.87ms 402.8±30.60ms -2.28%
block_apply/block_apply_1000 40.9±0.26s 40.9±0.26s 0.00%
get_with_proof/db_store 45.5±1.03µs 45.8±1.04µs -0.66%
get_with_proof/mem_store 35.2±0.89µs 35.6±1.07µs -1.12%
put_and_commit/db_store/1 729.4±54.07µs 709.4±27.87µs +2.82%
put_and_commit/db_store/10 1863.6±164.62µs 1859.2±165.83µs +0.24%
put_and_commit/db_store/100 10.3±0.74ms 10.1±0.72ms +1.98%
put_and_commit/db_store/5 1225.1±121.29µs 1234.5±129.94µs -0.76%
put_and_commit/db_store/50 5.8±0.44ms 5.8±0.39ms 0.00%
put_and_commit/mem_store/1 77.6±4.12µs 76.8±4.46µs +1.04%
put_and_commit/mem_store/10 696.1±33.05µs 691.1±34.62µs +0.72%
put_and_commit/mem_store/100 6.4±0.24ms 6.4±0.33ms 0.00%
put_and_commit/mem_store/5 352.8±18.41µs 349.3±18.84µs +1.00%
put_and_commit/mem_store/50 3.2±0.13ms 3.3±0.18ms -3.03%
query_block/query_block_in(10)_times(100) 1228.9±14.80µs 1301.6±12.16µs -5.59%
query_block/query_block_in(10)_times(1000) 12.3±0.08ms 13.1±0.09ms -6.11%
query_block/query_block_in(10)_times(10000) 122.5±1.19ms 130.4±1.16ms -6.06%
query_block/query_block_in(1000)_times(100) 1173.4±13.02µs 1226.4±10.22µs -4.32%
query_block/query_block_in(1000)_times(1000) 11.8±0.07ms 12.4±0.17ms -4.84%
query_block/query_block_in(1000)_times(10000) 118.9±0.70ms 123.4±0.68ms -3.65%
storage_transaction 19.6±0.46ms 19.7±0.61ms -0.51%
vm/transaction_execution/1 350.7±3.56ms 348.4±3.30ms +0.66%
vm/transaction_execution/10 109.4±0.71ms 110.6±2.68ms -1.08%
vm/transaction_execution/20 101.4±0.53ms 101.4±1.04ms 0.00%
vm/transaction_execution/5 134.9±1.99ms 134.0±1.46ms +0.67%
vm/transaction_execution/50 117.3±2.10ms 117.4±1.09ms -0.09%

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Benchmark for 90c433e

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1278.2±95.48µs 1288.9±78.94µs -0.83%
block_apply/block_apply_10 350.5±4.58ms 348.7±2.76ms +0.52%
block_apply/block_apply_1000 36.9±0.17s 36.8±0.24s +0.27%
get_with_proof/db_store 46.5±1.59µs 45.6±1.32µs +1.97%
get_with_proof/mem_store 36.7±0.94µs 36.2±0.65µs +1.38%
put_and_commit/db_store/1 546.3±30.26µs 568.9±160.71µs -3.97%
put_and_commit/db_store/10 1569.7±174.91µs 1683.9±456.95µs -6.78%
put_and_commit/db_store/100 10.3±3.02ms 10.5±3.81ms -1.90%
put_and_commit/db_store/5 1042.9±117.46µs 1060.9±154.32µs -1.70%
put_and_commit/db_store/50 5.6±0.43ms 5.6±0.37ms 0.00%
put_and_commit/mem_store/1 78.4±4.21µs 78.1±4.18µs +0.38%
put_and_commit/mem_store/10 692.4±33.97µs 706.5±33.39µs -2.00%
put_and_commit/mem_store/100 6.4±0.24ms 6.4±0.24ms 0.00%
put_and_commit/mem_store/5 354.4±21.73µs 358.0±19.63µs -1.01%
put_and_commit/mem_store/50 3.3±0.13ms 3.3±0.17ms 0.00%
query_block/query_block_in(10)_times(100) 1269.7±13.78µs 1305.6±9.70µs -2.75%
query_block/query_block_in(10)_times(1000) 12.5±0.10ms 13.0±0.17ms -3.85%
query_block/query_block_in(10)_times(10000) 128.0±1.28ms 130.8±0.75ms -2.14%
query_block/query_block_in(1000)_times(100) 1214.4±11.47µs 1253.1±3.90µs -3.09%
query_block/query_block_in(1000)_times(1000) 12.2±0.08ms 12.6±0.07ms -3.17%
query_block/query_block_in(1000)_times(10000) 122.5±0.22ms 124.3±0.37ms -1.45%
storage_transaction 15.1±0.79ms 15.4±0.70ms -1.95%
vm/transaction_execution/1 355.9±1.60ms 358.3±2.26ms -0.67%
vm/transaction_execution/10 110.4±0.46ms 111.5±0.95ms -0.99%
vm/transaction_execution/20 103.2±0.77ms 103.6±0.49ms -0.39%
vm/transaction_execution/5 135.7±0.89ms 136.4±1.15ms -0.51%
vm/transaction_execution/50 119.4±0.91ms 118.4±0.72ms +0.84%

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Benchmark for 4553add

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1466.6±85.09µs 1471.1±81.07µs -0.31%
block_apply/block_apply_10 391.2±1.90ms 392.2±2.21ms -0.25%
block_apply/block_apply_1000 41.0±0.09s 41.1±0.17s -0.24%
get_with_proof/db_store 45.5±1.49µs 45.2±0.69µs +0.66%
get_with_proof/mem_store 35.4±0.81µs 34.5±0.90µs +2.61%
put_and_commit/db_store/1 716.4±29.93µs 716.9±32.05µs -0.07%
put_and_commit/db_store/10 1834.9±175.90µs 1769.5±160.07µs +3.70%
put_and_commit/db_store/100 10.1±0.67ms 10.0±0.73ms +1.00%
put_and_commit/db_store/5 1243.1±122.68µs 1237.9±124.48µs +0.42%
put_and_commit/db_store/50 5.8±0.40ms 5.7±0.39ms +1.75%
put_and_commit/mem_store/1 76.9±4.70µs 74.6±4.42µs +3.08%
put_and_commit/mem_store/10 677.1±40.27µs 679.9±36.84µs -0.41%
put_and_commit/mem_store/100 6.3±0.25ms 6.3±0.24ms 0.00%
put_and_commit/mem_store/5 344.8±21.73µs 349.1±19.60µs -1.23%
put_and_commit/mem_store/50 3.2±0.17ms 3.2±0.17ms 0.00%
query_block/query_block_in(10)_times(100) 1284.4±15.95µs 1249.1±10.86µs +2.83%
query_block/query_block_in(10)_times(1000) 12.9±0.18ms 12.6±0.10ms +2.38%
query_block/query_block_in(10)_times(10000) 130.5±2.05ms 125.3±1.39ms +4.15%
query_block/query_block_in(1000)_times(100) 1222.8±15.40µs 1173.5±12.13µs +4.20%
query_block/query_block_in(1000)_times(1000) 12.4±0.06ms 11.7±0.15ms +5.98%
query_block/query_block_in(1000)_times(10000) 122.8±0.64ms 117.1±1.32ms +4.87%
storage_transaction 18.7±1.01ms 20.3±0.69ms -7.88%
vm/transaction_execution/1 344.4±3.41ms 342.3±3.67ms +0.61%
vm/transaction_execution/10 107.5±1.38ms 109.4±1.56ms -1.74%
vm/transaction_execution/20 99.1±1.02ms 98.8±1.15ms +0.30%
vm/transaction_execution/5 132.5±1.78ms 135.1±3.15ms -1.92%
vm/transaction_execution/50 116.3±1.31ms 116.6±1.19ms -0.26%

@ssyuan ssyuan merged commit ee40d74 into master Jan 8, 2021
@ssyuan ssyuan deleted the feature/config_refactor branch January 8, 2021 09:00
@jolestar jolestar linked an issue Jan 13, 2021 that may be closed by this pull request
[txpool] TxPool memory usage limit auto config #1634
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanne007 nanne007 nanne007 approved these changes

@jolestar jolestar jolestar approved these changes

@guangyuz guangyuz Awaiting requested review from guangyuz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Config [txpool] TxPool memory usage limit auto config
3 participants
@ssyuan @jolestar @nanne007