Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge all diem patches into several major ones #2219

Merged
merged 1 commit into from
Feb 26, 2021
Merged

merge all diem patches into several major ones #2219

merged 1 commit into from
Feb 26, 2021

Conversation

guangyuz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2219 (7320e06) into master (177b1ab) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
+ Coverage   33.95%   34.03%   +0.08%     
==========================================
  Files         481      481              
  Lines       40635    40635              
  Branches    17940    17940              
==========================================
+ Hits        13794    13825      +31     
+ Misses      13415    13336      -79     
- Partials    13426    13474      +48     
Flag Coverage Δ
unittests 34.03% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/src/consensus.rs 45.91% <0.00%> (-13.11%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
...p2p/src/protocol/generic_proto/handler/notif_in.rs 51.07% <0.00%> (-1.06%) ⬇️
...rk-p2p/src/protocol/generic_proto/handler/group.rs 34.06% <0.00%> (-0.72%) ⬇️
...rc/protocol/generic_proto/upgrade/notifications.rs 29.84% <0.00%> (-0.65%) ⬇️
types/src/block.rs 52.02% <0.00%> (-0.48%) ⬇️
network-p2p/src/protocol.rs 37.84% <0.00%> (ø)
sync/src/block_connector/test_illegal_block.rs 18.03% <0.00%> (ø)
vm/vm-runtime/src/starcoin_vm.rs 29.36% <0.00%> (+0.34%) ⬆️
rpc/client/src/lib.rs 14.93% <0.00%> (+0.48%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177b1ab...7320e06. Read the comment docs.

@github-actions
Copy link

Benchmark for 1b43505

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1509.9±62.84µs 1540.4±149.91µs -1.98%
block_apply/block_apply_10 412.5±8.16ms 401.2±1.73ms +2.82%
block_apply/block_apply_1000 42.8±0.21s 42.4±0.29s +0.94%
get_with_proof/db_store 45.1±1.00µs 45.2±0.82µs -0.22%
get_with_proof/mem_store 35.6±0.57µs 35.6±0.49µs 0.00%
put_and_commit/db_store/1 708.3±30.27µs 727.9±38.90µs -2.69%
put_and_commit/db_store/10 1885.6±171.70µs 1880.2±186.32µs +0.29%
put_and_commit/db_store/100 10.1±0.66ms 10.0±0.55ms +1.00%
put_and_commit/db_store/5 1265.1±115.11µs 1231.7±121.93µs +2.71%
put_and_commit/db_store/50 5.8±0.35ms 5.8±0.37ms 0.00%
put_and_commit/mem_store/1 76.6±4.16µs 78.1±3.99µs -1.92%
put_and_commit/mem_store/10 681.1±33.34µs 701.2±33.30µs -2.87%
put_and_commit/mem_store/100 6.4±0.29ms 6.4±0.23ms 0.00%
put_and_commit/mem_store/5 353.0±17.97µs 379.9±53.47µs -7.08%
put_and_commit/mem_store/50 3.3±0.18ms 3.2±0.11ms +3.13%
query_block/query_block_in(10)_times(100) 3.3±0.14ms 3.3±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 32.6±0.68ms 33.3±0.85ms -2.10%
query_block/query_block_in(10)_times(10000) 322.1±8.47ms 324.2±4.99ms -0.65%
query_block/query_block_in(1000)_times(100) 1402.1±8.47µs 1430.1±12.07µs -1.96%
query_block/query_block_in(1000)_times(1000) 14.2±0.13ms 14.4±0.11ms -1.39%
query_block/query_block_in(1000)_times(10000) 140.5±1.28ms 141.9±0.82ms -0.99%
storage_transaction 19.7±3.12ms 19.5±0.81ms +1.03%
vm/transaction_execution/1 395.2±1.20ms 405.4±8.16ms -2.52%
vm/transaction_execution/10 125.2±1.15ms 125.8±0.72ms -0.48%
vm/transaction_execution/20 118.7±4.96ms 118.8±1.21ms -0.08%
vm/transaction_execution/5 152.6±0.86ms 152.8±1.14ms -0.13%
vm/transaction_execution/50 134.2±1.39ms 135.3±1.15ms -0.81%

@jolestar jolestar merged commit 90eb734 into master Feb 26, 2021
@jolestar jolestar deleted the diem_patch branch February 26, 2021 10:59
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants