Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network-rpc & cmd]Add node network call_peer command for debug network rpc problem. #2223

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Mar 1, 2021

  1. 增加了一个命令,node network call_peer, 直接调用某个 peer 的 rpc 接口,用于诊断网络问题。
  2. 增加了一些 debug 日志。

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #2223 (6d75965) into master (cd03592) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2223      +/-   ##
==========================================
- Coverage   34.12%   33.92%   -0.19%     
==========================================
  Files         481      481              
  Lines       40635    40652      +17     
  Branches    17940    17947       +7     
==========================================
- Hits        13864    13789      -75     
- Misses      13277    13439     +162     
+ Partials    13494    13424      -70     
Flag Coverage Δ
unittests 33.92% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
network-p2p/types/src/lib.rs 38.10% <0.00%> (ø)
network-rpc/derive/src/to_client.rs 24.00% <ø> (ø)
network-rpc/derive/src/to_server.rs 38.71% <ø> (ø)
rpc/api/src/network_manager.rs 0.00% <0.00%> (ø)
rpc/client/src/lib.rs 14.36% <0.00%> (-0.57%) ⬇️
rpc/server/src/module/network_manager_rpc.rs 7.15% <0.00%> (-2.53%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
commons/service-registry/src/service_actor.rs 38.71% <0.00%> (-4.30%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd03592...6d75965. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Benchmark for 3463d14

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1175.4±70.17µs 1171.1±57.94µs +0.37%
block_apply/block_apply_10 351.8±1.08ms 362.7±11.02ms -3.01%
block_apply/block_apply_1000 37.9±0.15s 37.6±0.26s +0.80%
get_with_proof/db_store 45.9±0.76µs 45.7±1.59µs +0.44%
get_with_proof/mem_store 35.4±0.56µs 36.2±0.96µs -2.21%
put_and_commit/db_store/1 491.5±21.86µs 501.3±25.37µs -1.95%
put_and_commit/db_store/10 1589.5±97.29µs 1602.5±234.98µs -0.81%
put_and_commit/db_store/100 9.9±0.73ms 9.7±0.51ms +2.06%
put_and_commit/db_store/5 972.5±123.64µs 970.3±113.84µs +0.23%
put_and_commit/db_store/50 5.5±0.39ms 5.4±0.45ms +1.85%
put_and_commit/mem_store/1 76.5±4.05µs 79.5±4.75µs -3.77%
put_and_commit/mem_store/10 698.6±56.00µs 690.8±34.40µs +1.13%
put_and_commit/mem_store/100 6.5±0.57ms 6.4±0.28ms +1.56%
put_and_commit/mem_store/5 356.4±18.80µs 355.1±18.96µs +0.37%
put_and_commit/mem_store/50 3.3±0.14ms 3.3±0.14ms 0.00%
query_block/query_block_in(10)_times(100) 3.2±0.05ms 3.2±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 33.1±0.75ms 32.0±0.48ms +3.44%
query_block/query_block_in(10)_times(10000) 329.4±8.11ms 322.3±5.38ms +2.20%
query_block/query_block_in(1000)_times(100) 1443.8±16.12µs 1412.5±10.28µs +2.22%
query_block/query_block_in(1000)_times(1000) 14.1±0.14ms 14.1±0.12ms 0.00%
query_block/query_block_in(1000)_times(10000) 141.6±0.86ms 141.7±1.75ms -0.07%
storage_transaction 12.9±0.69ms 13.8±4.87ms -6.52%
vm/transaction_execution/1 401.9±3.22ms 396.9±1.81ms +1.26%
vm/transaction_execution/10 126.3±1.27ms 125.3±1.80ms +0.80%
vm/transaction_execution/20 117.9±1.81ms 116.7±1.43ms +1.03%
vm/transaction_execution/5 153.8±0.96ms 151.9±0.77ms +1.25%
vm/transaction_execution/50 135.1±0.83ms 134.9±1.34ms +0.15%

@ssyuan ssyuan merged commit 98bca31 into master Mar 1, 2021
@ssyuan ssyuan deleted the feature/network_rpc_cmd branch March 1, 2021 17:24
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…rk rpc problem. (starcoinorg#2223)

* [network-p2p] RequestFailure display output network fail detail.

* [network-rpc] Add more debug log for network-rpc client.

* [cmd] Add node network call_peer command for debug network rpc problem.

* [cmd] Add server debug log for network-rpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants