Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: list block return thin block #2254

Merged
merged 2 commits into from
Mar 9, 2021
Merged

rpc: list block return thin block #2254

merged 2 commits into from
Mar 9, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Mar 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2254 (0bccf69) into master (ff69818) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   34.06%   34.02%   -0.04%     
==========================================
  Files         482      482              
  Lines       40659    40666       +7     
  Branches    17988    17989       +1     
==========================================
- Hits        13846    13832      -14     
- Misses      13270    13321      +51     
+ Partials    13543    13513      -30     
Flag Coverage Δ
unittests 34.02% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/types.rs 17.72% <0.00%> (-0.18%) ⬇️
rpc/server/src/module/chain_rpc.rs 4.96% <0.00%> (-0.02%) ⬇️
miner/src/generate_block_event_pacemaker.rs 41.87% <0.00%> (-2.32%) ⬇️
...p2p/src/protocol/generic_proto/handler/notif_in.rs 51.07% <0.00%> (-1.06%) ⬇️
...rc/protocol/generic_proto/upgrade/notifications.rs 29.84% <0.00%> (-0.65%) ⬇️
types/src/block.rs 53.15% <0.00%> (-0.64%) ⬇️
sync/src/block_connector/test_illegal_block.rs 18.19% <0.00%> (-0.47%) ⬇️
...rk-p2p/src/protocol/generic_proto/handler/group.rs 34.06% <0.00%> (-0.36%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 28.60% <0.00%> (-0.28%) ⬇️
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff69818...0bccf69. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

Benchmark for 249cddd

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1290.8±94.52µs 1290.3±138.32µs +0.04%
block_apply/block_apply_10 372.3±1.84ms 378.3±15.33ms -1.59%
block_apply/block_apply_1000 42.0±1.92s 40.2±0.70s +4.48%
get_with_proof/db_store 43.5±1.43µs 43.6±0.54µs -0.23%
get_with_proof/mem_store 33.8±1.30µs 33.0±0.69µs +2.42%
put_and_commit/db_store/1 641.9±31.45µs 575.8±23.43µs +11.48%
put_and_commit/db_store/10 1647.1±119.53µs 1657.0±132.13µs -0.60%
put_and_commit/db_store/100 9.7±0.55ms 9.7±0.52ms 0.00%
put_and_commit/db_store/5 1130.6±85.35µs 1064.1±89.89µs +6.25%
put_and_commit/db_store/50 5.7±0.37ms 5.4±0.30ms +5.56%
put_and_commit/mem_store/1 74.5±4.49µs 73.5±3.69µs +1.36%
put_and_commit/mem_store/10 653.5±35.04µs 654.9±31.67µs -0.21%
put_and_commit/mem_store/100 6.1±0.21ms 6.1±0.26ms 0.00%
put_and_commit/mem_store/5 336.1±22.56µs 336.2±18.13µs -0.03%
put_and_commit/mem_store/50 3.1±0.13ms 3.1±0.16ms 0.00%
query_block/query_block_in(10)_times(100) 3.1±0.11ms 3.0±0.05ms +3.33%
query_block/query_block_in(10)_times(1000) 30.4±0.43ms 30.6±0.64ms -0.65%
query_block/query_block_in(10)_times(10000) 308.5±5.63ms 306.6±4.12ms +0.62%
query_block/query_block_in(1000)_times(100) 1379.8±38.64µs 1341.7±9.75µs +2.84%
query_block/query_block_in(1000)_times(1000) 13.6±0.46ms 13.4±0.10ms +1.49%
query_block/query_block_in(1000)_times(10000) 131.6±1.78ms 135.4±0.70ms -2.81%
storage_transaction 15.9±1.62ms 14.9±0.83ms +6.71%
vm/transaction_execution/1 375.3±3.09ms 375.9±1.44ms -0.16%
vm/transaction_execution/10 118.5±0.57ms 119.1±1.22ms -0.50%
vm/transaction_execution/20 110.4±0.56ms 110.5±0.76ms -0.09%
vm/transaction_execution/5 144.7±0.78ms 144.5±0.75ms +0.14%
vm/transaction_execution/50 126.9±0.57ms 128.1±1.30ms -0.94%

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Benchmark for e6ca6a8

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1247.8±61.98µs 1271.8±55.51µs -1.89%
block_apply/block_apply_10 376.2±26.10ms 367.6±1.47ms +2.34%
block_apply/block_apply_1000 38.5±0.17s 38.6±0.10s -0.26%
get_with_proof/db_store 42.0±0.66µs 41.6±0.51µs +0.96%
get_with_proof/mem_store 32.5±0.34µs 33.2±0.38µs -2.11%
put_and_commit/db_store/1 602.3±25.13µs 621.3±164.99µs -3.06%
put_and_commit/db_store/10 1586.2±106.54µs 1614.5±216.39µs -1.75%
put_and_commit/db_store/100 9.2±0.66ms 9.3±0.50ms -1.08%
put_and_commit/db_store/5 1054.1±90.09µs 1055.1±77.38µs -0.09%
put_and_commit/db_store/50 5.2±0.26ms 5.3±0.23ms -1.89%
put_and_commit/mem_store/1 71.2±3.68µs 71.8±3.55µs -0.84%
put_and_commit/mem_store/10 630.6±31.22µs 639.7±30.43µs -1.42%
put_and_commit/mem_store/100 6.0±0.56ms 6.1±0.54ms -1.64%
put_and_commit/mem_store/5 324.1±17.67µs 331.0±28.70µs -2.08%
put_and_commit/mem_store/50 3.0±0.14ms 3.1±0.12ms -3.23%
query_block/query_block_in(10)_times(100) 3.0±0.06ms 3.0±0.08ms 0.00%
query_block/query_block_in(10)_times(1000) 30.1±0.46ms 29.9±0.59ms +0.67%
query_block/query_block_in(10)_times(10000) 300.8±4.21ms 303.3±4.21ms -0.82%
query_block/query_block_in(1000)_times(100) 1291.1±4.83µs 1304.3±8.58µs -1.01%
query_block/query_block_in(1000)_times(1000) 13.0±0.10ms 12.9±0.04ms +0.78%
query_block/query_block_in(1000)_times(10000) 129.4±1.10ms 130.9±1.05ms -1.15%
storage_transaction 17.1±4.24ms 16.8±0.70ms +1.79%
vm/transaction_execution/1 370.8±1.41ms 374.8±11.55ms -1.07%
vm/transaction_execution/10 115.9±0.31ms 116.9±2.77ms -0.86%
vm/transaction_execution/20 109.6±2.07ms 108.0±0.45ms +1.48%
vm/transaction_execution/5 142.6±0.97ms 143.6±2.36ms -0.70%
vm/transaction_execution/50 124.7±2.23ms 124.9±1.26ms -0.16%

@nanne007 nanne007 merged commit d2d2d52 into master Mar 9, 2021
@nanne007 nanne007 deleted the rpc/update_list_block branch March 9, 2021 01:41
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Co-authored-by: jolestar <jolestar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants