Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] migrated to new constraint system #2270

Merged
merged 8 commits into from
Mar 15, 2021
Merged

[move] migrated to new constraint system #2270

merged 8 commits into from
Mar 15, 2021

Conversation

guangyuz
Copy link
Contributor

No description provided.

@guangyuz guangyuz marked this pull request as draft March 11, 2021 11:20
@codecov
Copy link

codecov bot commented Mar 11, 2021 •
edited
Loading

Codecov Report

Merging #2270 (13e6c28) into master (b50e36f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
+ Coverage   34.03%   34.05%   +0.02%     
==========================================
  Files         483      483              
  Lines       40688    40688              
  Branches    17990    17990              
==========================================
+ Hits        13846    13853       +7     
+ Misses      13321    13304      -17     
- Partials    13521    13531      +10
Flag Coverage Δ
unittests 34.05% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executor/src/module_compatibility_test.rs 0.00% <ø> (ø)
executor/src/readonly_function_call_test.rs 13.64% <ø> (ø)
...2p/src/protocol/generic_proto/handler/notif_out.rs 36.42% <0.00%> (-3.26%) ⬇️
...rk-p2p/src/protocol/generic_proto/handler/group.rs 32.61% <0.00%> (-1.44%) ⬇️
...re/forkable-jellyfish-merkle/src/tree_cache/mod.rs 70.24% <0.00%> (-1.19%) ⬇️
commons/stream-task/src/collector.rs 58.17% <0.00%> (-1.02%) ⬇️
sync/src/block_connector/test_illegal_block.rs 18.35% <0.00%> (-0.15%) ⬇️
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
network-p2p/src/protocol.rs 37.84% <0.00%> (ø)
network-p2p/peerset/src/lib.rs 39.41% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50e36f...13e6c28. Read the comment docs.

@github-actions
Copy link

Benchmark for a6f4225

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1302.5±248.39µs 1303.2±96.30µs -0.05%
block_apply/block_apply_10 378.2±12.34ms 375.5±7.86ms +0.72%
block_apply/block_apply_1000 39.5±0.22s 39.3±0.19s +0.51%
get_with_proof/db_store 43.4±1.16µs 43.2±0.89µs +0.46%
get_with_proof/mem_store 33.8±0.73µs 33.4±0.41µs +1.20%
put_and_commit/db_store/1 611.7±56.15µs 591.6±74.90µs +3.40%
put_and_commit/db_store/10 1682.5±139.38µs 1644.5±123.90µs +2.31%
put_and_commit/db_store/100 9.7±0.52ms 9.5±0.41ms +2.11%
put_and_commit/db_store/5 1119.3±105.26µs 1086.7±109.12µs +3.00%
put_and_commit/db_store/50 5.7±1.79ms 5.4±0.26ms +5.56%
put_and_commit/mem_store/1 73.2±3.89µs 73.9±3.75µs -0.95%
put_and_commit/mem_store/10 652.4±33.83µs 659.0±34.98µs -1.00%
put_and_commit/mem_store/100 6.0±0.22ms 6.1±0.24ms -1.64%
put_and_commit/mem_store/5 334.4±17.68µs 341.6±17.03µs -2.11%
put_and_commit/mem_store/50 3.1±0.15ms 3.3±0.26ms -6.06%
query_block/query_block_in(10)_times(100) 3.1±0.06ms 3.1±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 30.8±0.93ms 30.1±0.85ms +2.33%
query_block/query_block_in(10)_times(10000) 311.4±3.05ms 304.1±7.67ms +2.40%
query_block/query_block_in(1000)_times(100) 1380.4±28.92µs 1303.6±9.16µs +5.89%
query_block/query_block_in(1000)_times(1000) 13.8±0.15ms 13.1±0.11ms +5.34%
query_block/query_block_in(1000)_times(10000) 144.3±5.82ms 131.5±1.36ms +9.73%
storage_transaction 14.8±0.73ms 14.5±1.31ms +2.07%
vm/transaction_execution/1 380.8±5.38ms 376.9±3.39ms +1.03%
vm/transaction_execution/10 121.0±1.53ms 120.5±4.01ms +0.41%
vm/transaction_execution/20 111.9±1.26ms 110.5±0.65ms +1.27%
vm/transaction_execution/5 147.1±2.51ms 144.8±1.00ms +1.59%
vm/transaction_execution/50 128.2±1.45ms 129.2±3.62ms -0.77%

@guangyuz guangyuz marked this pull request as ready for review March 12, 2021 10:32
@github-actions
Copy link

Benchmark for 67e0e51

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1275.0±57.31µs 1286.5±77.95µs -0.89%
block_apply/block_apply_10 383.8±26.67ms 375.9±11.62ms +2.10%
block_apply/block_apply_1000 40.3±0.86s 39.8±0.14s +1.26%
get_with_proof/db_store 43.6±1.25µs 43.8±0.95µs -0.46%
get_with_proof/mem_store 33.4±0.65µs 33.8±0.79µs -1.18%
put_and_commit/db_store/1 555.5±22.40µs 562.9±23.13µs -1.31%
put_and_commit/db_store/10 1591.8±105.54µs 1678.8±193.03µs -5.18%
put_and_commit/db_store/100 9.8±1.82ms 10.2±2.37ms -3.92%
put_and_commit/db_store/5 1068.0±91.06µs 1070.0±89.49µs -0.19%
put_and_commit/db_store/50 5.5±0.27ms 5.6±0.24ms -1.79%
put_and_commit/mem_store/1 73.4±3.81µs 73.1±3.76µs +0.41%
put_and_commit/mem_store/10 645.0±30.91µs 651.7±31.41µs -1.03%
put_and_commit/mem_store/100 6.1±0.25ms 6.1±0.20ms 0.00%
put_and_commit/mem_store/5 334.5±17.99µs 337.7±17.11µs -0.95%
put_and_commit/mem_store/50 3.1±0.12ms 3.1±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 3.1±0.08ms 3.0±0.16ms +3.33%
query_block/query_block_in(10)_times(1000) 30.9±0.38ms 30.2±0.65ms +2.32%
query_block/query_block_in(10)_times(10000) 306.9±7.49ms 302.3±3.68ms +1.52%
query_block/query_block_in(1000)_times(100) 1358.0±12.00µs 1330.5±25.78µs +2.07%
query_block/query_block_in(1000)_times(1000) 13.5±0.09ms 13.2±0.16ms +2.27%
query_block/query_block_in(1000)_times(10000) 135.9±0.71ms 133.8±1.98ms +1.57%
storage_transaction 15.1±3.56ms 14.1±0.75ms +7.09%
vm/transaction_execution/1 378.8±1.34ms 378.3±1.27ms +0.13%
vm/transaction_execution/10 119.3±0.65ms 119.4±0.44ms -0.08%
vm/transaction_execution/20 111.9±0.74ms 111.4±0.68ms +0.45%
vm/transaction_execution/5 146.5±1.31ms 145.9±0.97ms +0.41%
vm/transaction_execution/50 128.6±0.88ms 127.7±0.81ms +0.70%

@github-actions
Copy link

Benchmark for 5c5f3d5

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1203.2±67.41µs 1218.6±83.20µs -1.26%
block_apply/block_apply_10 356.2±2.25ms 359.0±3.60ms -0.78%
block_apply/block_apply_1000 37.9±0.11s 37.8±0.13s +0.26%
get_with_proof/db_store 42.4±0.53µs 42.4±0.76µs 0.00%
get_with_proof/mem_store 32.4±0.23µs 32.9±0.57µs -1.52%
put_and_commit/db_store/1 537.3±35.00µs 534.3±23.73µs +0.56%
put_and_commit/db_store/10 1627.0±158.94µs 1583.0±94.22µs +2.78%
put_and_commit/db_store/100 9.6±2.25ms 9.2±0.41ms +4.35%
put_and_commit/db_store/5 1013.9±84.63µs 998.3±78.21µs +1.56%
put_and_commit/db_store/50 5.3±0.26ms 5.2±0.26ms +1.92%
put_and_commit/mem_store/1 72.0±3.61µs 73.0±3.81µs -1.37%
put_and_commit/mem_store/10 642.5±29.74µs 641.2±30.39µs +0.20%
put_and_commit/mem_store/100 6.1±0.55ms 6.1±0.55ms 0.00%
put_and_commit/mem_store/5 328.0±16.12µs 330.0±17.02µs -0.61%
put_and_commit/mem_store/50 3.1±0.13ms 3.0±0.22ms +3.33%
query_block/query_block_in(10)_times(100) 3.0±0.08ms 3.1±0.11ms -3.23%
query_block/query_block_in(10)_times(1000) 29.7±0.54ms 30.3±0.57ms -1.98%
query_block/query_block_in(10)_times(10000) 302.3±8.04ms 305.8±5.33ms -1.14%
query_block/query_block_in(1000)_times(100) 1313.9±5.39µs 1310.7±4.39µs +0.24%
query_block/query_block_in(1000)_times(1000) 13.0±0.09ms 13.2±0.10ms -1.52%
query_block/query_block_in(1000)_times(10000) 131.2±2.19ms 131.6±0.59ms -0.30%
storage_transaction 11.8±0.58ms 12.1±0.77ms -2.48%
vm/transaction_execution/1 380.2±6.04ms 372.2±3.00ms +2.15%
vm/transaction_execution/10 118.7±0.80ms 117.5±0.81ms +1.02%
vm/transaction_execution/20 110.9±2.33ms 109.2±0.96ms +1.56%
vm/transaction_execution/5 144.8±1.71ms 143.8±1.23ms +0.70%
vm/transaction_execution/50 127.6±2.57ms 125.9±0.89ms +1.35%

@github-actions
Copy link

Benchmark for 6981722

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1339.6±84.25µs 1412.3±207.41µs -5.15%
block_apply/block_apply_10 374.9±1.98ms 402.4±4.27ms -6.83%
block_apply/block_apply_1000 40.3±1.66s 43.6±0.11s -7.57%
get_with_proof/db_store 45.1±0.84µs 46.1±1.08µs -2.17%
get_with_proof/mem_store 35.3±1.06µs 34.7±0.44µs +1.73%
put_and_commit/db_store/1 629.6±24.90µs 618.1±26.58µs +1.86%
put_and_commit/db_store/10 1803.1±148.30µs 1792.7±152.20µs +0.58%
put_and_commit/db_store/100 10.8±0.70ms 10.8±0.54ms 0.00%
put_and_commit/db_store/5 1178.1±82.96µs 1216.2±189.69µs -3.13%
put_and_commit/db_store/50 6.0±0.29ms 6.3±1.62ms -4.76%
put_and_commit/mem_store/1 75.6±4.05µs 75.0±3.95µs +0.80%
put_and_commit/mem_store/10 680.5±34.33µs 667.3±34.43µs +1.98%
put_and_commit/mem_store/100 6.4±0.30ms 6.3±0.26ms +1.59%
put_and_commit/mem_store/5 349.2±17.66µs 347.6±18.13µs +0.46%
put_and_commit/mem_store/50 3.2±0.17ms 3.2±0.13ms 0.00%
query_block/query_block_in(10)_times(100) 3.1±0.05ms 3.1±0.09ms 0.00%
query_block/query_block_in(10)_times(1000) 30.9±0.54ms 31.5±1.20ms -1.90%
query_block/query_block_in(10)_times(10000) 310.5±4.90ms 313.1±4.20ms -0.83%
query_block/query_block_in(1000)_times(100) 1371.2±14.10µs 1387.5±21.55µs -1.17%
query_block/query_block_in(1000)_times(1000) 13.8±0.24ms 14.3±0.26ms -3.50%
query_block/query_block_in(1000)_times(10000) 137.7±2.09ms 141.1±2.05ms -2.41%
storage_transaction 15.6±0.75ms 16.0±0.86ms -2.50%
vm/transaction_execution/1 395.5±3.28ms 394.3±4.98ms +0.30%
vm/transaction_execution/10 123.4±1.29ms 123.6±0.67ms -0.16%
vm/transaction_execution/20 115.5±1.53ms 114.8±0.94ms +0.61%
vm/transaction_execution/5 151.4±1.21ms 151.2±1.74ms +0.13%
vm/transaction_execution/50 131.8±1.11ms 132.1±2.51ms -0.23%

@github-actions
Copy link

Benchmark for a42fc97

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1267.0±64.34µs 1321.5±83.48µs -4.12%
block_apply/block_apply_10 367.7±1.45ms 372.0±6.08ms -1.16%
block_apply/block_apply_1000 38.9±0.16s 39.2±0.25s -0.77%
get_with_proof/db_store 42.9±0.64µs 44.0±0.81µs -2.50%
get_with_proof/mem_store 33.7±0.72µs 33.2±0.65µs +1.51%
put_and_commit/db_store/1 589.2±202.30µs 590.1±22.52µs -0.15%
put_and_commit/db_store/10 1765.6±496.80µs 1668.5±116.33µs +5.82%
put_and_commit/db_store/100 10.0±0.65ms 9.7±0.52ms +3.09%
put_and_commit/db_store/5 1042.5±94.85µs 1096.3±96.15µs -4.91%
put_and_commit/db_store/50 5.3±0.26ms 5.5±0.31ms -3.64%
put_and_commit/mem_store/1 72.5±3.85µs 74.8±3.76µs -3.07%
put_and_commit/mem_store/10 643.8±32.31µs 659.5±38.09µs -2.38%
put_and_commit/mem_store/100 6.1±0.59ms 6.2±0.22ms -1.61%
put_and_commit/mem_store/5 332.3±18.15µs 337.3±17.22µs -1.48%
put_and_commit/mem_store/50 3.1±0.13ms 3.1±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 3.1±0.09ms 3.1±0.08ms 0.00%
query_block/query_block_in(10)_times(1000) 30.9±1.32ms 30.2±0.38ms +2.32%
query_block/query_block_in(10)_times(10000) 304.5±4.68ms 302.8±4.73ms +0.56%
query_block/query_block_in(1000)_times(100) 1345.3±11.26µs 1327.1±21.02µs +1.37%
query_block/query_block_in(1000)_times(1000) 13.4±0.23ms 13.1±0.12ms +2.29%
query_block/query_block_in(1000)_times(10000) 134.5±0.93ms 131.3±0.58ms +2.44%
storage_transaction 13.3±0.79ms 14.8±0.78ms -10.14%
vm/transaction_execution/1 375.8±1.00ms 378.7±1.49ms -0.77%
vm/transaction_execution/10 117.6±0.35ms 119.9±0.82ms -1.92%
vm/transaction_execution/20 109.0±0.47ms 111.3±0.76ms -2.07%
vm/transaction_execution/5 144.5±1.38ms 147.0±2.88ms -1.70%
vm/transaction_execution/50 125.7±0.56ms 128.9±1.90ms -2.48%

@jolestar jolestar merged commit 007f210 into master Mar 15, 2021
@jolestar jolestar deleted the abilities branch March 15, 2021 02:52
@guangyuz guangyuz restored the abilities branch April 8, 2021 14:22
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
@guangyuz @jolestar @naughtyvenom
[move] migrated to new constraint system (starcoinorg#2270)
3fa5c6f 
* [move] migrate to new constraint system

* [stdlib] migrated stdlib to the new constraints system

* [test] migrated functional test to abilities

* [prover] fix move prover

* fix unit tests and re-generate genesis
 - ignore test_that_rust_code_compiles

* ignore test_that_installed_rust_code_compiles

* fix integration tests

Co-authored-by: jolestar <jolestar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guangyuz @jolestar