Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: add tx status log #2271

Merged
merged 1 commit into from
Mar 15, 2021
Merged

log: add tx status log #2271

merged 1 commit into from
Mar 15, 2021

Conversation

nanne007
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2271 (5eacc14) into master (07fea8b) will increase coverage by 0.04%.
The diff coverage is 48.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
+ Coverage   33.97%   34.01%   +0.04%     
==========================================
  Files         483      483              
  Lines       40663    40688      +25     
  Branches    17988    17990       +2     
==========================================
+ Hits        13810    13834      +24     
+ Misses      13381    13343      -38     
- Partials    13472    13511      +39     
Flag Coverage Δ
unittests 34.01% <48.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
txpool/src/pool/queue.rs 26.95% <ø> (ø)
txpool/src/pool/listener.rs 51.52% <48.00%> (-1.18%) ⬇️
commons/service-registry/src/bus/mod.rs 35.30% <0.00%> (-9.80%) ⬇️
miner/src/generate_block_event_pacemaker.rs 41.87% <0.00%> (-2.32%) ⬇️
sync/src/block_connector/write_block_chain.rs 34.58% <0.00%> (-1.06%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 28.60% <0.00%> (-0.57%) ⬇️
...rk-p2p/src/protocol/generic_proto/handler/group.rs 34.06% <0.00%> (-0.36%) ⬇️
...able-jellyfish-merkle/src/jellyfish_merkle_test.rs 18.85% <0.00%> (-0.22%) ⬇️
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
commons/stream-task/src/tests.rs 29.96% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07fea8b...5eacc14. Read the comment docs.

@github-actions
Copy link

Benchmark for 606945f

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1226.2±96.83µs 1320.1±152.77µs -7.11%
block_apply/block_apply_10 378.0±7.55ms 376.1±8.55ms +0.51%
block_apply/block_apply_1000 39.5±0.13s 39.3±0.24s +0.51%
get_with_proof/db_store 43.2±0.88µs 43.8±0.97µs -1.37%
get_with_proof/mem_store 33.9±0.87µs 34.5±1.37µs -1.74%
put_and_commit/db_store/1 565.9±34.64µs 588.3±45.75µs -3.81%
put_and_commit/db_store/10 1634.0±123.70µs 1653.7±136.14µs -1.19%
put_and_commit/db_store/100 9.4±0.65ms 9.7±0.48ms -3.09%
put_and_commit/db_store/5 1079.7±92.98µs 1090.2±109.32µs -0.96%
put_and_commit/db_store/50 5.3±0.27ms 5.5±0.38ms -3.64%
put_and_commit/mem_store/1 72.6±4.24µs 73.8±4.19µs -1.63%
put_and_commit/mem_store/10 651.2±32.81µs 658.1±30.89µs -1.05%
put_and_commit/mem_store/100 6.1±0.24ms 6.1±0.27ms 0.00%
put_and_commit/mem_store/5 332.7±17.28µs 343.8±18.36µs -3.23%
put_and_commit/mem_store/50 3.1±0.14ms 3.1±0.16ms 0.00%
query_block/query_block_in(10)_times(100) 3.1±0.10ms 3.0±0.08ms +3.33%
query_block/query_block_in(10)_times(1000) 31.3±0.67ms 30.8±1.25ms +1.62%
query_block/query_block_in(10)_times(10000) 307.9±2.72ms 306.6±5.95ms +0.42%
query_block/query_block_in(1000)_times(100) 1349.2±48.46µs 1335.1±6.72µs +1.06%
query_block/query_block_in(1000)_times(1000) 13.3±0.21ms 13.1±0.07ms +1.53%
query_block/query_block_in(1000)_times(10000) 133.6±0.61ms 131.4±0.80ms +1.67%
storage_transaction 15.2±2.01ms 15.1±5.40ms +0.66%
vm/transaction_execution/1 378.8±3.81ms 380.7±4.88ms -0.50%
vm/transaction_execution/10 119.2±1.10ms 120.8±2.05ms -1.32%
vm/transaction_execution/20 116.3±6.07ms 114.4±5.35ms +1.66%
vm/transaction_execution/5 145.3±1.07ms 148.7±3.79ms -2.29%
vm/transaction_execution/50 131.7±7.19ms 129.3±2.53ms +1.86%

pub struct StatusLogger;
impl StatusLogger {
fn log_status(tx: &Arc<Transaction>, status: TxStatus) {
debug!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该 info?debug 默认不开。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是默认不开。这个日志太多了。
我们测试用,就打开 RUST_LOG=tx-status=debug。

@jolestar jolestar merged commit b50e36f into master Mar 15, 2021
@jolestar jolestar deleted the log/tx-status branch March 15, 2021 01:27
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants