Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selecting peers use formula: max(MIN, min(MAX, sqrt(x))) #2309

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

nanne007
Copy link
Member

close #2307

@nanne007 nanne007 requested a review from jolestar March 22, 2021 03:39
@github-actions
Copy link

Benchmark for 1770613

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1253.5±91.91µs 1217.7±62.07µs +2.94%
block_apply/block_apply_10 369.2±2.80ms 369.0±2.14ms +0.05%
block_apply/block_apply_1000 39.1±0.19s 39.1±0.20s 0.00%
get_with_proof/db_store 43.5±0.96µs 42.9±0.70µs +1.40%
get_with_proof/mem_store 32.8±0.70µs 32.8±0.60µs 0.00%
put_and_commit/db_store/1 543.2±35.56µs 516.2±31.95µs +5.23%
put_and_commit/db_store/10 1655.8±100.49µs 1662.4±86.84µs -0.40%
put_and_commit/db_store/100 9.7±0.57ms 9.5±0.43ms +2.11%
put_and_commit/db_store/5 1037.8±134.45µs 1007.7±94.83µs +2.99%
put_and_commit/db_store/50 5.5±1.45ms 5.4±0.37ms +1.85%
put_and_commit/mem_store/1 73.2±3.77µs 73.6±4.58µs -0.54%
put_and_commit/mem_store/10 642.0±31.30µs 650.7±33.22µs -1.34%
put_and_commit/mem_store/100 6.0±0.20ms 6.1±0.21ms -1.64%
put_and_commit/mem_store/5 330.6±17.72µs 337.1±16.99µs -1.93%
put_and_commit/mem_store/50 3.1±0.12ms 3.1±0.17ms 0.00%
query_block/query_block_in(10)_times(100) 3.2±0.04ms 3.2±0.05ms 0.00%
query_block/query_block_in(10)_times(1000) 32.5±0.56ms 32.0±0.78ms +1.56%
query_block/query_block_in(10)_times(10000) 328.6±16.06ms 321.0±4.19ms +2.37%
query_block/query_block_in(1000)_times(100) 1370.8±19.93µs 1320.5±5.73µs +3.81%
query_block/query_block_in(1000)_times(1000) 13.7±0.18ms 13.1±0.09ms +4.58%
query_block/query_block_in(1000)_times(10000) 137.4±0.90ms 131.6±0.60ms +4.41%
storage_transaction 12.4±0.84ms 13.0±3.50ms -4.62%
vm/transaction_execution/1 382.1±1.00ms 382.1±1.96ms 0.00%
vm/transaction_execution/10 123.9±0.51ms 124.0±1.29ms -0.08%
vm/transaction_execution/20 115.9±1.08ms 115.2±0.69ms +0.61%
vm/transaction_execution/5 150.3±0.78ms 150.1±1.16ms +0.13%
vm/transaction_execution/50 132.3±1.15ms 132.0±1.27ms +0.23%

@github-actions
Copy link

Benchmark for 187fb8a

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1009.6±50.81µs 1040.4±62.84µs -2.96%
block_apply/block_apply_10 336.5±3.22ms 332.9±4.49ms +1.08%
block_apply/block_apply_1000 35.0±0.43s 35.3±0.33s -0.85%
get_with_proof/db_store 43.2±0.78µs 43.5±1.19µs -0.69%
get_with_proof/mem_store 33.2±0.86µs 34.0±0.67µs -2.35%
put_and_commit/db_store/1 513.5±27.75µs 375.9±50.61µs +36.61%
put_and_commit/db_store/10 1419.6±61.74µs 1409.4±69.93µs +0.72%
put_and_commit/db_store/100 9.0±0.43ms 9.4±0.57ms -4.26%
put_and_commit/db_store/5 830.5±78.77µs 848.7±101.07µs -2.14%
put_and_commit/db_store/50 5.0±0.28ms 5.0±0.28ms 0.00%
put_and_commit/mem_store/1 75.2±4.06µs 75.2±4.60µs 0.00%
put_and_commit/mem_store/10 660.5±30.78µs 649.3±34.99µs +1.72%
put_and_commit/mem_store/100 6.1±0.24ms 6.2±0.23ms -1.61%
put_and_commit/mem_store/5 335.5±17.44µs 332.0±17.77µs +1.05%
put_and_commit/mem_store/50 3.2±0.17ms 3.1±0.14ms +3.23%
query_block/query_block_in(10)_times(100) 3.3±0.05ms 3.2±0.09ms +3.13%
query_block/query_block_in(10)_times(1000) 32.7±0.97ms 32.4±1.01ms +0.93%
query_block/query_block_in(10)_times(10000) 326.7±4.11ms 325.0±6.45ms +0.52%
query_block/query_block_in(1000)_times(100) 1358.0±25.86µs 1345.7±11.26µs +0.91%
query_block/query_block_in(1000)_times(1000) 13.5±0.12ms 13.7±0.13ms -1.46%
query_block/query_block_in(1000)_times(10000) 135.3±1.99ms 139.1±2.06ms -2.73%
storage_transaction 9.3±0.36ms 9.4±0.34ms -1.06%
vm/transaction_execution/1 386.0±2.33ms 384.1±2.84ms +0.49%
vm/transaction_execution/10 124.9±1.14ms 124.3±0.85ms +0.48%
vm/transaction_execution/20 116.0±1.03ms 116.2±0.95ms -0.17%
vm/transaction_execution/5 151.4±1.35ms 151.2±1.57ms +0.13%
vm/transaction_execution/50 132.8±1.62ms 131.4±1.54ms +1.07%

@jolestar jolestar merged commit 194cade into master Mar 22, 2021
@jolestar jolestar deleted the fix/select-peers branch March 22, 2021 08:28
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Random peers select do not guarantee min peers.
2 participants