Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm] switch script function argument type to bcs bytes #2326

Merged
merged 5 commits into from
Mar 25, 2021
Merged

[vm] switch script function argument type to bcs bytes #2326

merged 5 commits into from
Mar 25, 2021

Conversation

guangyuz
Copy link
Contributor

No description provided.

@github-actions
Copy link

Benchmark for f8862ed

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1264.8±34.86µs 1290.1±104.79µs -1.96%
block_apply/block_apply_10 374.4±2.15ms 372.8±2.28ms +0.43%
block_apply/block_apply_1000 39.3±0.23s 38.4±0.30s +2.34%
get_with_proof/db_store 42.9±0.52µs 42.5±1.03µs +0.94%
get_with_proof/mem_store 33.1±0.57µs 32.9±0.64µs +0.61%
put_and_commit/db_store/1 607.9±25.41µs 602.8±27.47µs +0.85%
put_and_commit/db_store/10 1620.0±121.03µs 1675.5±79.43µs -3.31%
put_and_commit/db_store/100 9.2±0.42ms 9.2±0.41ms 0.00%
put_and_commit/db_store/5 1056.5±79.21µs 1051.0±90.40µs +0.52%
put_and_commit/db_store/50 5.3±0.24ms 5.3±0.23ms 0.00%
put_and_commit/mem_store/1 70.9±3.78µs 72.2±3.71µs -1.80%
put_and_commit/mem_store/10 637.9±32.45µs 641.2±31.25µs -0.51%
put_and_commit/mem_store/100 6.1±0.60ms 6.1±0.54ms 0.00%
put_and_commit/mem_store/5 329.1±19.36µs 329.4±17.74µs -0.09%
put_and_commit/mem_store/50 3.0±0.14ms 3.0±0.12ms 0.00%
query_block/query_block_in(10)_times(100) 3.3±0.10ms 3.2±0.06ms +3.13%
query_block/query_block_in(10)_times(1000) 32.8±0.72ms 32.4±0.51ms +1.23%
query_block/query_block_in(10)_times(10000) 325.6±5.35ms 324.9±3.82ms +0.22%
query_block/query_block_in(1000)_times(100) 1308.3±6.98µs 1295.4±4.44µs +1.00%
query_block/query_block_in(1000)_times(1000) 12.9±0.09ms 12.8±0.09ms +0.78%
query_block/query_block_in(1000)_times(10000) 131.4±0.85ms 128.6±0.91ms +2.18%
storage_transaction 17.7±0.76ms 17.9±1.63ms -1.12%
vm/transaction_execution/1 379.0±2.26ms 376.8±3.05ms +0.58%
vm/transaction_execution/10 120.7±0.63ms 122.7±1.13ms -1.63%
vm/transaction_execution/20 113.3±1.23ms 113.4±1.06ms -0.09%
vm/transaction_execution/5 148.2±0.66ms 147.9±1.53ms +0.20%
vm/transaction_execution/50 129.6±0.49ms 129.7±1.22ms -0.08%

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2326 (fd6d020) into master (897867e) will decrease coverage by 0.05%.
The diff coverage is 3.75%.

❗ Current head fd6d020 differs from pull request most recent head b397541. Consider uploading reports for the commit b397541 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2326      +/-   ##
==========================================
- Coverage   33.54%   33.50%   -0.04%     
==========================================
  Files         477      478       +1     
  Lines       41100    41134      +34     
  Branches    18343    18443     +100     
==========================================
- Hits        13784    13778       -6     
+ Misses      13533    13410     -123     
- Partials    13783    13946     +163     
Flag Coverage Δ
unittests 33.50% <3.75%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/dev/tests.rs 15.08% <0.00%> (-0.79%) ⬇️
executor/src/executor_test.rs 14.87% <0.00%> (-0.61%) ⬇️
executor/src/stdlib_test/module_upgrade_test.rs 16.13% <0.00%> (-4.83%) ⬇️
rpc/api/src/types.rs 17.07% <0.00%> (-1.01%) ⬇️
vm/transaction-builder/src/lib.rs 29.01% <0.00%> (-20.43%) ⬇️
vm/types/src/lib.rs 33.34% <ø> (ø)
vm/types/src/proptest_types.rs 48.86% <0.00%> (-0.38%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 29.44% <0.00%> (ø)
test-helper/src/dao.rs 28.86% <2.39%> (-7.00%) ⬇️
executor/src/account.rs 44.52% <25.00%> (+0.14%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897867e...b397541. Read the comment docs.

@github-actions
Copy link

Benchmark for 2c2d9a2

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1197.7±76.48µs 1214.7±72.94µs -1.40%
block_apply/block_apply_10 365.5±2.42ms 375.8±24.98ms -2.74%
block_apply/block_apply_1000 38.5±0.14s 37.4±0.56s +2.94%
get_with_proof/db_store 42.0±1.23µs 42.3±0.65µs -0.71%
get_with_proof/mem_store 32.7±0.75µs 32.3±0.50µs +1.24%
put_and_commit/db_store/1 549.8±84.85µs 541.4±28.18µs +1.55%
put_and_commit/db_store/10 1632.4±172.09µs 1614.3±81.07µs +1.12%
put_and_commit/db_store/100 9.6±2.36ms 9.2±0.50ms +4.35%
put_and_commit/db_store/5 1018.9±86.85µs 1032.6±162.51µs -1.33%
put_and_commit/db_store/50 5.2±0.27ms 5.2±0.25ms 0.00%
put_and_commit/mem_store/1 71.3±3.58µs 71.6±3.64µs -0.42%
put_and_commit/mem_store/10 642.0±55.67µs 643.1±31.39µs -0.17%
put_and_commit/mem_store/100 6.0±0.52ms 6.0±0.51ms 0.00%
put_and_commit/mem_store/5 324.1±16.36µs 332.0±16.90µs -2.38%
put_and_commit/mem_store/50 3.0±0.14ms 3.0±0.16ms 0.00%
query_block/query_block_in(10)_times(100) 3.2±0.07ms 3.3±0.05ms -3.03%
query_block/query_block_in(10)_times(1000) 32.7±0.57ms 32.7±0.45ms 0.00%
query_block/query_block_in(10)_times(10000) 326.3±8.57ms 325.8±4.54ms +0.15%
query_block/query_block_in(1000)_times(100) 1343.7±14.19µs 1335.8±6.50µs +0.59%
query_block/query_block_in(1000)_times(1000) 13.6±0.07ms 13.4±0.48ms +1.49%
query_block/query_block_in(1000)_times(10000) 133.9±0.38ms 133.8±0.63ms +0.07%
storage_transaction 13.1±0.79ms 13.0±0.56ms +0.77%
vm/transaction_execution/1 376.7±1.70ms 378.1±2.43ms -0.37%
vm/transaction_execution/10 120.9±1.68ms 123.5±1.83ms -2.11%
vm/transaction_execution/20 112.5±1.09ms 114.9±1.56ms -2.09%
vm/transaction_execution/5 147.5±0.99ms 149.4±1.00ms -1.27%
vm/transaction_execution/50 129.6±1.46ms 129.7±1.12ms -0.08%

@jolestar jolestar merged commit 73c32f1 into master Mar 25, 2021
@jolestar jolestar deleted the vm branch March 25, 2021 14:56
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
)

* [vm] upgrade vm to 03_25

* switch to bcs bytes for txn args in script function

* fix unit tests and fmt

* fix test_modify_on_chain_config_consensus_by_dao

Co-authored-by: jolestar <jolestar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants